Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tagged GTIDs in Previous-GTIDs events #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EeshwarPrasath
Copy link

@EeshwarPrasath EeshwarPrasath commented Oct 27, 2024

Previously, we were unable to parse Tagged GTIDs in Previous-GTIDs events since the tags and its related data were embedded differently inside the Previous-GTIDs events whenever the tags were enabled, and trying to parse them always throwed exceptions.

This PR solves the issue mentioned here: osheroff#158 (comment)

@jpechane
Copy link

jpechane commented Oct 30, 2024

@EeshwarPrasath Hi, thanks for the PR. IT looks good yet, I'd like to have it tested to. Would it be possible to add an integration test that will enable tagged transaction and run it against MySQL 8.4? We'd then add MySQL 8.4 test workflow to the GitHub repository.

It would bprobably need few more steps

@EeshwarPrasath
Copy link
Author

Hi @jpechane,

Thank you for reviewing the PR and providing detailed instructions. I’m happy to work on the integration test as requested. However, adding support for MySQL 8.4 to onetimeserver is taking longer than anticipated due to some complexities.

If anyone else from the community has insights or suggestions for adding MySQL 8.4 support to onetimeserver, I’d appreciate the input.

Thanks for your understanding.

@jpechane
Copy link

@EeshwarPrasath Thanks! BTW, for our purposes I believe it is sufficient to do support for Linux only. In future i can imagine we'd replace this approach with TestContainers as the way easier solution to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants