-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #26
base: master
Are you sure you want to change the base?
Dev #26
Conversation
xuebingjie1990
commented
Feb 22, 2021
•
edited
Loading
edited
- update pipeline to work with new BedBaseConf / pipestat
- pre-compute trackHub dir
update dev with master change
create trackHub directories for the BED sets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also work on code style/formatting. I noticed things like:
- mixed use of
''
and""
for strings - lines over 80 chars
- missing spaces between function parameters
pipelines/bedbuncher.py
Outdated
'shortLabel': 'BEDBASE_'+args.bedset_name, | ||
'longLabel': args.bedset_name + ' signal tracks', | ||
'genomesFile': "genomes.txt", | ||
'email': '[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to some lab email?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what email should I use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the one we use for auto uploading software to pypi? I can't seem to find it. @nsheff do you remember the email address?
@stolarczyk do you have a linting system you recommend for Python style to help people become familiar with good style? |
no, but adding one is a great idea. I'll see what are the options and test things out. |
it looks like black is the most used one, it's also developed by a Python core developer. I tested it in bbconf and it worked perfectly fine: https://github.com/databio/bbconf/pull/9/checks?check_run_id=1954455626 What's interesting, the default line length cutoff is 88: https://black.readthedocs.io/en/stable/the_black_code_style.html#line-length |