Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Dev #26

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Dev #26

wants to merge 46 commits into from

Conversation

xuebingjie1990
Copy link
Member

@xuebingjie1990 xuebingjie1990 commented Feb 22, 2021

  • update pipeline to work with new BedBaseConf / pipestat
  • pre-compute trackHub dir

Copy link
Member

@stolarczyk stolarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also work on code style/formatting. I noticed things like:

  • mixed use of '' and "" for strings
  • lines over 80 chars
  • missing spaces between function parameters

'shortLabel': 'BEDBASE_'+args.bedset_name,
'longLabel': args.bedset_name + ' signal tracks',
'genomesFile': "genomes.txt",
'email': '[email protected]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to some lab email?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what email should I use?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the one we use for auto uploading software to pypi? I can't seem to find it. @nsheff do you remember the email address?

@nsheff
Copy link
Member

nsheff commented Feb 22, 2021

@stolarczyk do you have a linting system you recommend for Python style to help people become familiar with good style?

@stolarczyk
Copy link
Member

no, but adding one is a great idea. I'll see what are the options and test things out.

@stolarczyk
Copy link
Member

stolarczyk commented Feb 22, 2021

it looks like black is the most used one, it's also developed by a Python core developer. I tested it in bbconf and it worked perfectly fine: https://github.com/databio/bbconf/pull/9/checks?check_run_id=1954455626

What's interesting, the default line length cutoff is 88: https://black.readthedocs.io/en/stable/the_black_code_style.html#line-length

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants