feat!: Asset Lock Chain Lock Proof #203

shuplenkov · 2021-04-16T16:00:41Z

Issue being fixed or feature implemented

What was done?

Integrated new DPP version
Introduced StateTransition class

How Has This Been Tested?

Tests

Breaking Changes

Will not work with previous version of DPP

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

lgtm-com · 2021-04-16T16:03:41Z

This pull request introduces 2 alerts when merging cf8b73a into 3a6945c - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-04-20T11:00:06Z

This pull request introduces 2 alerts when merging 6287963 into 3a6945c - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-04-20T11:11:08Z

This pull request introduces 2 alerts when merging 87adca3 into 3a6945c - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-04-20T14:45:21Z

This pull request introduces 2 alerts when merging d488c42 into 7bdcd8e - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

# Conflicts: # package.json

lgtm-com · 2021-04-21T09:00:53Z

This pull request introduces 2 alerts when merging 1db41cd into 57f2bb9 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-04-21T10:09:30Z

This pull request introduces 2 alerts when merging efdf0a6 into 495f981 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-04-23T12:16:11Z

This pull request introduces 2 alerts and fixes 1 when merging f1cf201 into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-23T13:25:12Z

This pull request introduces 2 alerts and fixes 1 when merging b03a8d7 into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-23T14:03:43Z

This pull request introduces 2 alerts and fixes 1 when merging 0efadbb into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-23T15:32:22Z

This pull request introduces 2 alerts and fixes 1 when merging 77d6eb8 into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-23T15:45:20Z

This pull request introduces 2 alerts and fixes 1 when merging ae78fbe into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-26T14:14:27Z

This pull request introduces 2 alerts and fixes 1 when merging 7b2c01f into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-26T15:26:16Z

This pull request introduces 2 alerts and fixes 1 when merging 72b11a8 into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

# Conflicts: # .github/workflows/.env

lgtm-com · 2021-04-27T09:42:48Z

This pull request introduces 2 alerts and fixes 1 when merging 3d4d578 into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

shumkov · 2021-04-27T10:01:32Z

.github/workflows/.env

+DRIVE_BRANCH=new-dpp
+DAPI_BRANCH=new-dpp


We can keep it empty after releasing DAPI and Drive

shumkov · 2021-04-27T10:04:58Z

src/SDK/Client/Platform/StateRepository.ts

+  }
+
+  async verifyInstantLock(): Promise<boolean> {
+    return true;


Please add a comment, that verification will be implemented later with DAPI SPV functionality

shumkov · 2021-04-27T10:05:45Z

src/SDK/Client/Platform/StateRepository.ts

+    return {
+      // @ts-ignore
+      data: transaction.toBuffer(),
+      height: 1,


Please add a comment, that we don't have transaction heights atm and it will be implemented later with DAPI SPV

lgtm-com · 2021-04-27T10:18:49Z

This pull request introduces 2 alerts and fixes 1 when merging cc4e07d into f88ff2f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-04-27T11:06:52Z

This pull request fixes 1 alert when merging 9220d48 into f88ff2f - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

shumkov

LGTM!

lgtm-com · 2021-04-27T12:17:22Z

This pull request fixes 1 alert when merging 2681308 into f88ff2f - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

feat: integrate dpp with Chain Lock Proof support

cf8b73a

shuplenkov added this to the v0.19 milestone Apr 16, 2021

shuplenkov requested review from shumkov, antouhou and jawid-h April 16, 2021 16:00

feat: integrate dpp with Chain Lock Proof support

6287963

feat: integrate dpp with Chain Lock Proof support

87adca3

shumkov changed the title ~~feat: integrate dpp with Chain Lock Proof support~~ feat!: Asset Lock Chain Lock Proof Apr 20, 2021

Merge branch 'v0.19-dev' into new-dpp

d488c42

Konstantin Shuplenkov added 2 commits April 21, 2021 11:55

Merge branch 'v0.19-dev' into new-dpp

99690a8

# Conflicts: # package.json

chore: merge with 0.19

1db41cd

Konstantin Shuplenkov added 2 commits April 21, 2021 13:03

feat: stateRepository as class

562b983

Merge branch 'v0.19-dev' into new-dpp

efdf0a6

fix: bugfix

f1cf201

debug

b03a8d7

debug

0efadbb

debug

77d6eb8

debug

ae78fbe

debug

7b2c01f

debug

72b11a8

Konstantin Shuplenkov added 3 commits April 27, 2021 11:25

chore: set proper branches for github actions

0514e74

feat: update dpp to 0.19.0-dev.4

92c5113

Merge branch 'v0.19-dev' into new-dpp

3d4d578

# Conflicts: # .github/workflows/.env

shumkov reviewed Apr 27, 2021

View reviewed changes

chore: add some comments

cc4e07d

fix: lgtm alerts

9220d48

chore: set proper branches for github actions

2681308

shumkov approved these changes Apr 27, 2021

View reviewed changes

shuplenkov merged commit 1b45606 into v0.19-dev Apr 27, 2021

shumkov deleted the new-dpp branch May 5, 2021 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Asset Lock Chain Lock Proof #203

feat!: Asset Lock Chain Lock Proof #203

shuplenkov commented Apr 16, 2021 •

edited

Loading

lgtm-com bot commented Apr 16, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 21, 2021

lgtm-com bot commented Apr 21, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 26, 2021

lgtm-com bot commented Apr 26, 2021

lgtm-com bot commented Apr 27, 2021

shumkov Apr 27, 2021

shumkov Apr 27, 2021

shumkov Apr 27, 2021

lgtm-com bot commented Apr 27, 2021

lgtm-com bot commented Apr 27, 2021

shumkov left a comment

lgtm-com bot commented Apr 27, 2021

		DRIVE_BRANCH=new-dpp
		DAPI_BRANCH=new-dpp

feat!: Asset Lock Chain Lock Proof #203

feat!: Asset Lock Chain Lock Proof #203

Conversation

shuplenkov commented Apr 16, 2021 • edited Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

lgtm-com bot commented Apr 16, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 20, 2021

lgtm-com bot commented Apr 21, 2021

lgtm-com bot commented Apr 21, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 23, 2021

lgtm-com bot commented Apr 26, 2021

lgtm-com bot commented Apr 26, 2021

lgtm-com bot commented Apr 27, 2021

shumkov Apr 27, 2021

Choose a reason for hiding this comment

shumkov Apr 27, 2021

Choose a reason for hiding this comment

shumkov Apr 27, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Apr 27, 2021

lgtm-com bot commented Apr 27, 2021

shumkov left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Apr 27, 2021

shuplenkov commented Apr 16, 2021 •

edited

Loading