Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

feat: remove fake instant locks proofs #198

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Conversation

antouhou
Copy link
Contributor

Issue being fixed or feature implemented

Removed fake instant locks proofs since mn-bootstrap can produce normal proofs in CI now

What was done?

Remove fallback and fallback options

How Has This Been Tested?

Run the unit test

Breaking Changes

Remove 'passFakeInstantLocksForTest' option from the client constrcutor

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lgtm-com
Copy link

lgtm-com bot commented Mar 15, 2021

This pull request introduces 1 alert when merging 2d2b95d into 26bd7d8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 3e20658 into 26bd7d8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 288b7c2 into 26bd7d8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 5a354b6 into 26bd7d8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 3a6945c into v0.19-dev Apr 1, 2021
@shumkov shumkov deleted the feat-remove-is-fakes branch April 1, 2021 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants