Merge pull request #12 from dart-lang/infinity

fix an issue with double.INFINITY

CHANGELOG.md

@@ -1,3 +1,5 @@
-## 1.0.0
+## 1.0.0+1
+* Fix an issue with converting `double.INFINITY`.
 
+## 1.0.0
 * Initial version.

lib/src/changes.dart

@@ -49,11 +49,11 @@ final Map<String, String> _textReplacements = {
   'DateTime.DECEMBER': 'DateTime.december',
   'DateTime.MONTHS_PER_YEAR': 'DateTime.monthsPerYear',
 
-  'double.NAN': 'DateTime.nan',
-  'double.INFINITY': 'DateTime.infinity',
-  'double.NEGATIVE_INFINITY': 'DateTime.negativeInfinity',
-  'double.MIN_POSITIVE': 'DateTime.minPositive',
-  'double.MAX_FINITE': 'DateTime.maxFinite',
+  'double.NAN': 'double.nan',
+  'double.INFINITY': 'double.infinity',
+  'double.NEGATIVE_INFINITY': 'double.negativeInfinity',
+  'double.MIN_POSITIVE': 'double.minPositive',
+  'double.MAX_FINITE': 'double.maxFinite',
 
   'Duration.MICROSECONDS_PER_MILLISECOND':
       'Duration.microsecondsPerMillisecond',

pubspec.yaml

@@ -2,7 +2,7 @@ name: dart2_fix
 author: Dart Team <[email protected]>
 description: A tool to migrate API usage to Dart 2.
 homepage: https://github.com/dart-lang/dart2_fix
-version: 1.0.0
+version: 1.0.0+1
 
 environment:
   sdk: '>=1.20.1 <2.0.0'

test/data/sample.dart

@@ -5,4 +5,5 @@ void main() {
   print(PI); // dart:math
   print(JSON); // dart:convert
   print(Duration.ZERO); // dart:core
+  print(double.INFINITY); // dart:core
 }

test/integration_test.dart

@@ -19,10 +19,11 @@ void main() {
       expect(result.result, 0);
 
       String out = logger.stdOutput.toString();
-      expect(out, contains('line 5 • PI => pi'));
-      expect(out, contains('line 6 • JSON => json'));
-      expect(out, contains('line 7 • Duration.ZERO => Duration.zero'));
-      expect(out, contains('Found 3 fixes'));
+      expect(out, contains('line 5 - PI => pi'));
+      expect(out, contains('line 6 - JSON => json'));
+      expect(out, contains('line 7 - Duration.ZERO => Duration.zero'));
+      expect(out, contains('line 8 - double.INFINITY => double.infinity'));
+      expect(out, contains('Found 4 fixes'));
     });
   });
 }
@@ -33,7 +34,7 @@ class BufferLogger implements Logger {
 
   BufferLogger() {}
 
-  final Ansi ansi = new Ansi(false);
+  final Ansi ansi = new TestAnsi();
 
   void flush() {}
 
@@ -73,3 +74,9 @@ class _SimpleProgress implements Progress {
 
   void finish({String message, bool showTiming}) {}
 }
+
+class TestAnsi extends Ansi {
+  TestAnsi() : super(false);
+
+  String get bullet => '-';
+}