This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(template_cache_generator): support traversal of partial files #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,6 +119,14 @@ class TemplateCollectingVisitor { | |||
| this.sourceCrawler); | |||
|
|
|||
| call(CompilationUnitElement cue, String srcPath) { | |||
There was a problem hiding this comment.
I would add void return type here
|
Please make sure to follow commit comments guidelines described in https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md LGTM |
|
I updated the title a bit. Don't know if it's enough to follow the guidelines, but it looks kind-of like other pull requests I think... Feedback appreciated! |
|
you should update the commit comments rather than the PR title, also you can squash both commits: Thanks |
|
OK, better now? |
|
👍 |
|
Landed as f918d4d, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662