This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(dccd): add Support for ObservableList, ObservableMap & ChangeNotifi... #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirayuk
force-pushed
the
master
branch
2 times, most recently
from
8fd235c to
50e2645
Compare
|
@rkirov This commit should do the trick - see the rationale in the comment. Note: you should probably add the same kind of test for Maps. |
|
Great, thanks Vic. You commit fixed the list, but now that I added the map tests, they fail too. Can you take a look again. |
|
I can not test today but it seems you are only calling detect change (getting the it) once in this test. Try to call it twice as you do for lists - this one should not work when not using observable, right ? |
|
Yeah, that does it. |
rkirov
force-pushed
the
observable
branch
2 times, most recently
from
cea5b84 to
6debf5b
Compare
…ifier Lower the target time to prevent a memory overflow. Benchmark added. To use annotate your models with @observable or use ObservableList or ObservableMap. Fixes dart-archive#773 Closes dart-archive#1156
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...er
Lower the target time to prevent a memory overflow. Benchmark added.
Rebased and squashed @vicb's work in #1156.
Fixes #773
Closes #1156