This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fitest(ngModel): Do not use input selection*
IDL attributes for input type=number tests Fix#588 Closes#589
- Loading branch information
Showing
1 changed file
with
24 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhevery for some reason #588 and #589 are not showing up as closed on my side. Is there something special you or I needed to do or is this meant to be automatic. If the latter, then it may be because of the lack of space characters in the commit message just before the issue number: namely "Closes#589" rather than "Closes #589". Maybe just a minor bookkeeping issue but I figured I would point it out in case it affects something (e.g., automated change log generation scripts).
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhevery. One more question about the commit title: is "fitest" a label new category, maybe meant to be "fixtest"? Either way, if so, I can update the CONTRIBUTING.md to reflect this new category; and while I am at it, I would suggest broadening the "test" category: it currently reads:
Is "adding missing tests" the only reason "test" should be used? What if tests are refactored or fixed or improved?
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a "refactor" category, so I don't think it's necessary to broaden the "tests" category.
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgourlie: possibly, but the categories/types "feat", "fix", "refactor" etc seem to implicitly apply to the angular.dart code proper, not the tests. Otherwise, the "test" category would be superfluous --- one could simply use "feat" to indicate the addition of a new test.
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I am not saying that I am right in my interpretation, I have just wondered a few times, how to structure my commit title when e.g., work is only done on tests.
c09745b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the noise @mhevery, it seems that I had the privileges to mark #588 and #589 as merged and closed. Done.