Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Commit

Permalink
chore(dart2js): Re-enable tests that were disabled because of V8 bug …
Browse files Browse the repository at this point in the history
…in Chrome 33.

Closes #878
  • Loading branch information
kasperl authored and mhevery committed Apr 11, 2014
1 parent c73a0c7 commit 356df76
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 31 deletions.
2 changes: 1 addition & 1 deletion pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ packages:
route_hierarchical:
description: route_hierarchical
source: hosted
version: "0.4.15"
version: "0.4.18"
shadow_dom:
description: shadow_dom
source: hosted
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
html5lib: '>=0.9.2 <0.10.0'
intl: '>=0.8.7 <0.10.0'
perf_api: '>=0.0.8 <0.1.0'
route_hierarchical: '>=0.4.7 <0.5.0'
route_hierarchical: '>=0.4.18 <0.5.0'
shadow_dom: '>=0.9.1 <1.0.0'
dev_dependencies:
benchmark_harness: '>=1.0.0'
Expand Down
49 changes: 22 additions & 27 deletions test/routing/ng_view_spec.dart
Original file line number Diff line number Diff line change
Expand Up @@ -101,33 +101,28 @@ main() {
'<h2>Read Book 1234</h2>'));
});

// This test is disable on dart2js because it is flaky
// on dart v1.2. Kasper is looking into it. In the
// meantime we are disabling it.
if (!identical(1, 1.0)) {
it('should switch nested templates', async(() {
Element root = _.compile('<ng-view></ng-view>');
expect(root.text).toEqual('');

router.route('/library/all');
microLeap();
expect(root.text).toEqual('LibraryBooks');

router.route('/library/1234');
microLeap();
expect(root.text).toEqual('LibraryBook 1234');

// nothing should change here
router.route('/library/1234/overview');
microLeap();
expect(root.text).toEqual('LibraryBook 1234');

// nothing should change here
router.route('/library/1234/read');
microLeap();
expect(root.text).toEqual('LibraryRead Book 1234');
}));
}
it('should switch nested templates', async(() {
Element root = _.compile('<ng-view></ng-view>');
expect(root.text).toEqual('');

router.route('/library/all');
microLeap();
expect(root.text).toEqual('LibraryBooks');

router.route('/library/1234');
microLeap();
expect(root.text).toEqual('LibraryBook 1234');

// nothing should change here
router.route('/library/1234/overview');
microLeap();
expect(root.text).toEqual('LibraryBook 1234');

// nothing should change here
router.route('/library/1234/read');
microLeap();
expect(root.text).toEqual('LibraryRead Book 1234');
}));
});
}

Expand Down
2 changes: 0 additions & 2 deletions test/routing/routing_spec.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import 'package:angular/angular_dynamic.dart';
import 'dart:async';

main() {
// Do not run in dart2js until the exception is fixed
if (identical(1.0, 1)) return;
describe('routing', () {
TestBed _;
Router router;
Expand Down

0 comments on commit 356df76

Please sign in to comment.