feat!: release v6 #81
Merged
+31
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Setting an initial state for a cookie (i.e. enabled instead of disabled) was never properly implemented. To avoid confusion, this setting is removed. It continues to be possible to set `isIframeBlocked` true, though as of 2022-03-30 it is not yet implemented for vite (#79).
|
@darioferderber do you think it's fine to remove the initial cookie setting (enabled / disabled)? I think it's required by common law to let the user turn on cookies / give consent. Or are there situations in which a cookie might need to be enabled through the module configuration? |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@dargmuesli Sure, I think we can remove the initial cookie setting. Once I had a request to implement that, but I think that's kind of a grey zone regarding the low, so yes, we can remove it 🙂 |
If you mean conflicts on this PR, then I'd wait with that. I want to merge your proposed changes into the beta branch as well to save on one major update 🙌 |
Conflicts: .github/workflows/ci.yml .github/workflows/release-schedule.yml package.json pnpm-lock.yaml src/runtime/components/CookieControl.vue
BREAKING CHANGE: remove stale `domain` configuration option feat: add `cookieOptions` configuration option Co-authored-by: Jonas Thelemann <[email protected]>
dargmuesli
added a commit
that referenced
this pull request
Jul 12, 2023
# [6.0.0](5.10.4...6.0.0) (2023-07-12) * feat!: release v6 (#81) ([feb598a](feb598a)), closes [#81](#81) [#100](#100) [#106](#106) ### BREAKING CHANGES * Setting an initial state for a cookie (i.e. enabled instead of disabled) was never properly implemented. To avoid confusion, this setting is removed. It continues to be possible to set `isIframeBlocked` true, though as of 2022-03-30 it is not yet implemented for vite (#79). * chore(deps): update dependency typescript to v5.0.3 * chore(deps): update dependency @nuxt/kit to v3.3.3 * chore(deps): update dependency nuxt to v3.3.3 * chore(deps): update dargmuesli/github-actions action to v0.35.6 * chore(deps): update dependency webpack to v5.78.0 * chore(deps): update dependency lint-staged to v13.2.1 * chore(deps): update dependency typescript to v5.0.4 * chore(deps): update dependency eslint to v8.38.0 * chore(deps): update dependency @nuxt/kit to v3.4.0 * chore(deps): update dargmuesli/github-actions action to v0.35.7 * chore(deps): update dependency @nuxt/module-builder to v0.3.0 * chore(deps): update dependency webpack to v5.79.0 * chore(deps): update dependency @nuxt/kit to v3.4.1 * chore(deps): update dependency nuxt to v3.4.1 * chore(deps): lock file maintenance * chore(deps): update dargmuesli/github-actions action to v0.35.8 * chore(deps): update dependency webpack to v5.80.0 * chore(deps): update dependency @nuxt/kit to v3.4.2 * chore(deps): update dependency nuxt to v3.4.2 * chore(deps): update dependency vue-tsc to v1.4.1 * chore(deps): update dependency vue-tsc to v1.4.2 * chore(deps): update dependency js-cookie to v3.0.4 * chore(deps): update dependency eslint to v8.39.0 * chore(deps): update dependency vue-tsc to v1.4.3 * chore(deps): update dependency vue-tsc to v1.4.4 * chore(deps): update dependency prettier to v2.8.8 * chore(deps): update dargmuesli/github-actions action to v0.36.0 * chore(deps): update dependency js-cookie to v3.0.5 * chore(deps): update dargmuesli/github-actions action to v0.37.2 * chore(deps): update dargmuesli/github-actions action to v0.37.3 * chore(deps): update dependency lint-staged to v13.2.2 * chore(deps): update dependency webpack to v5.81.0 * chore(deps): update dependency vue-tsc to v1.6.0 * chore(deps): update dependency vue-tsc to v1.6.1 * chore(deps): update dependency @nuxt/kit to v3.4.3 * chore(deps): update dependency nuxt to v3.4.3 * chore(deps): lock file maintenance * chore(deps): update dependency vue-tsc to v1.6.2 * chore(deps): update dependency @nuxt/module-builder to v0.3.1 * chore(deps): update dependency vue-tsc to v1.6.3 * chore(deps): update dargmuesli/github-actions action to v0.37.4 * chore(deps): update dependency webpack to v5.82.0 * chore(deps): update dependency vue-tsc to v1.6.4 * chore(deps): update dependency eslint to v8.40.0 * chore(deps): update pnpm to v8.5.0 * chore(deps): update dargmuesli/github-actions action to v0.38.1 * chore(deps): update dependency webpack to v5.82.1 * remove stale `domain` configuration option feat: add `cookieOptions` configuration option Co-authored-by: Jonas Thelemann <[email protected]>
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
BREAKING CHANGE: Setting an initial state for a cookie (i.e. enabled instead of disabled) was never properly implemented. To avoid confusion, this setting is removed. It continues to be possible to set
isIframeBlockedtrue, though as of 2022-03-30 it is not yet implemented for vite (#79).BREAKING CHANGE: The stale
domainconfiguration option is removed. Instead, thecookieOptionsconfiguration option is now available that allows to change all cookies' options.📝 Checklist