Skip to content

Commit

Permalink
Merge pull request #283 from dappnode/mateu/integrate-smooth-fr-changes
Browse files Browse the repository at this point in the history
Integrate Smooth Fee recipient changes
  • Loading branch information
pablomendezroyo authored Jan 24, 2024
2 parents 4e6d695 + 7ac3073 commit 3f2a022
Show file tree
Hide file tree
Showing 7 changed files with 567 additions and 89 deletions.
14 changes: 12 additions & 2 deletions packages/common/src/params.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
export const burnAddress = "0x0000000000000000000000000000000000000000";
export const BURN_ADDRESS = "0x0000000000000000000000000000000000000000";

//Rocket Pool Fee Recipient depends on the network (mainnet, goerli)
// Rocket Pool Fee Recipient is the same for both networks (mainnet and prater)
export const rocketPoolFeeRecipient =
"0xd4E96eF8eee8678dBFf4d535E033Ed1a4F7605b7";

export const ROCKET_POOL_FEE_RECIPIENT =
"0xd4E96eF8eee8678dBFf4d535E033Ed1a4F7605b7" as const;

export const MEV_SP_ADDRESS_PRATER =
"0xF21fbbA423f3a893A2402d68240B219308AbCA46" as const;

// TODO: Put the mainnet address here
export const MEV_SP_ADDRESS_MAINNET =
"0xAdFb8D27671F14f297eE94135e266aAFf8752e35" as const;
6 changes: 3 additions & 3 deletions packages/ui/src/ImportScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
Web3signerPostResponse,
Tag,
isValidEcdsaPubkey,
burnAddress,
BURN_ADDRESS,
CustomImportRequest,
isFeeRecipientEditable,
areAllFeeRecipientsEditable,
Expand Down Expand Up @@ -131,7 +131,7 @@ export default function ImportScreen({
if (!isValidEcdsaPubkey(feeRecipient)) {
return "Invalid address";
}
if (feeRecipient === burnAddress) {
if (feeRecipient === BURN_ADDRESS) {
return "It is not possible to set the fee recipient to the burn address";
}
return "Address is valid";
Expand All @@ -143,7 +143,7 @@ export default function ImportScreen({
if (feeRecipient === "" || feeRecipient === undefined) {
return false;
}
if (!isValidEcdsaPubkey(feeRecipient) || feeRecipient === burnAddress) {
if (!isValidEcdsaPubkey(feeRecipient) || feeRecipient === BURN_ADDRESS) {
return true;
}

Expand Down
Loading

0 comments on commit 3f2a022

Please sign in to comment.