Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drain stdout and stderr concurrently #636

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

jflan-dd
Copy link
Contributor

Same motivation as #614, but for when stderr fills up first.

Can be manually verified using:

let shell = ShellExecutor()
let result = try shell.spawn("hexdump /dev/urandom | head -c 500000 1>&2", arguments: [])

Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jflan-dd
Copy link
Contributor Author

Thanks for the review and approval @f-meloni!

I don't have permission to merge the PR on my own. Could you merge it as well?

@f-meloni f-meloni merged commit eac3e07 into danger:master Feb 1, 2025
14 checks passed
@jflan-dd jflan-dd deleted the jflan/drain-stderr branch February 3, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants