Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin-web small issues #283

Merged
merged 4 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/src/components/molecules/DAGAttributes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function DAGAttributes({ dag: config }: Props) {
</LabeledItem>
<LabeledItem label="Description">{config.Description}</LabeledItem>
<LabeledItem label="Max Active Runs">{config.MaxActiveRuns}</LabeledItem>
<LabeledItem label="Params">{config.Params}</LabeledItem>
<LabeledItem label="Params">{config.Params?.join(" ")}</LabeledItem>
<Stack direction={'column'}>
<React.Fragment>
<LabeledItem label="Preconditions">{null}</LabeledItem>
Expand Down
4 changes: 2 additions & 2 deletions admin/src/components/molecules/DAGSpecErrors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ function DAGSpecErrors({ errors }: Props) {
<div>Please check the below errors!</div>
<div className="content">
<ul>
{errors.map((e) => (
<li>{e}</li>
{errors.map((e, i) => (
<li key={`${i}`}>{e}</li>
))}
</ul>
</div>
Expand Down
7 changes: 5 additions & 2 deletions admin/src/pages/dags/dag/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function DAGDetails() {
const { mutate } = useSWRConfig();

const refreshFn = React.useCallback(() => {
mutate(baseUrl);
mutate(`${baseUrl}/*`);
return;
}, [mutate, baseUrl]);

Expand Down Expand Up @@ -124,7 +124,10 @@ function DAGDetails() {
<Route
path={'/history'}
element={
<ExecutionHistory logData={data.LogData} isLoading={isValidating} />
<ExecutionHistory
logData={data.LogData}
isLoading={isValidating}
/>
}
/>
<Route
Expand Down
3 changes: 1 addition & 2 deletions admin/src/pages/dags/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ function DAGs() {
});

const refreshFn = React.useCallback(() => {
mutate('/');
return;
mutate('*');
}, [mutate]);

React.useEffect(() => {
Expand Down
4 changes: 4 additions & 0 deletions examples/named_params.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
params: "FOO=foo BAR=bar"
steps:
- name: step1
command: echo $FOO-$BAR