Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed View feature #192

Merged
merged 1 commit into from
Jul 7, 2022
Merged

refactor: removed View feature #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions admin/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import React from "react";
import { BrowserRouter, Routes, Route } from "react-router-dom";
import DashboardLayout from "./DashboardLayout";
import Dashboard from "./pages/Dashboard";
import View from "./pages/View";
import ViewList from "./pages/ViewList";
import DAGDetails from "./pages/DAGDetails";
import DAGs from "./pages/DAGs";

Expand All @@ -23,8 +21,6 @@ function App({ config }: Props) {
<Routes>
<Route path="/" element={<Dashboard />} />
<Route path="" element={<DAGs />} />
<Route path="/views" element={<ViewList />} />
<Route path="/views/:name" element={<View />} />
<Route path="/dags/" element={<DAGs />} />
<Route path="/dags/:name" element={<DAGDetails />} />
</Routes>
Expand Down
4 changes: 0 additions & 4 deletions admin/src/DashboardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ function DashboardContent({
{[
["/", "Dashboard"],
["/dags", "DAGs"],
["/views", "Views"],
].map((v) => (
<Link
key={v[0]}
Expand Down Expand Up @@ -203,9 +202,6 @@ function DashboardContent({
<Toolbar />
<Grid container sx={{ mt: 4, mb: 4 }}>
{children}
{/* <Grid item xs={12} sx={{ mt: 4 }}>
<Copyright />
</Grid> */}
</Grid>
</Box>
</Box>
Expand Down
154 changes: 0 additions & 154 deletions admin/src/components/CreateViewButton.tsx
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions admin/src/components/ViewActions.tsx
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions admin/src/components/ViewTable.tsx
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions admin/src/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import ListItemButton from "@mui/material/ListItemButton";
import ListItemIcon from "@mui/material/ListItemIcon";
import ListItemText from "@mui/material/ListItemText";
import LayersIcon from "@mui/icons-material/Layers";
import FilterAltIcon from '@mui/icons-material/FilterAlt';
import FilterAltIcon from "@mui/icons-material/FilterAlt";
import DashboardIcon from "@mui/icons-material/Dashboard";
import { Link } from "react-router-dom";

Expand All @@ -25,13 +25,5 @@ export const mainListItems = (
<ListItemText primary="DAGs" />
</ListItemButton>
</Link>
<Link to="/views">
<ListItemButton>
<ListItemIcon>
<FilterAltIcon />
</ListItemIcon>
<ListItemText primary="Views" />
</ListItemButton>
</Link>
</React.Fragment>
);
2 changes: 0 additions & 2 deletions admin/src/pages/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ function Dashboard() {
</Grid>
))}

{/* {data?.DAGs ? ( */}
<Grid item xs={12}>
<Paper
sx={{
Expand All @@ -84,7 +83,6 @@ function Dashboard() {
<DashboardTimechart data={data?.DAGs || []} />
</Paper>
</Grid>
{/* ) : null} */}
</Grid>
);
}
Expand Down
Loading