Improve the test coverage (#649)

cmd/dry.go

@@ -36,7 +36,6 @@ func dryCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Failed to load config: %v", err)
 			}
 			initLogger := logger.NewLogger(logger.NewLoggerArgs{

cmd/scheduler.go

@@ -34,7 +34,6 @@ func schedulerCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, _ []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Configuration load failed: %v", err)
 			}
 			logger := logger.NewLogger(logger.NewLoggerArgs{

cmd/server.go

@@ -39,7 +39,6 @@ func serverCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, _ []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Configuration load failed: %v", err)
 			}
 			logger := logger.NewLogger(logger.NewLoggerArgs{
@@ -53,7 +52,6 @@ func serverCmd() *cobra.Command {
 			cli := newClient(cfg, dataStore, logger)
 			server := frontend.New(cfg, logger, cli)
 			if err := server.Serve(cmd.Context()); err != nil {
-				// nolint
 				logger.Error("Server initialization failed", "error", err)
 				os.Exit(1)
 			}

cmd/start.go

@@ -36,7 +36,6 @@ func startCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Configuration load failed: %v", err)
 			}
 

cmd/start_all.go

@@ -29,11 +29,9 @@ import (
 
 func startAllCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use: "start-all",
-		// nolint
+		Use:   "start-all",
 		Short: "Launches both the Dagu web UI server and the scheduler process.",
-		// nolint
-		Long: `dagu start-all [--dags=<DAGs dir>] [--host=<host>] [--port=<port>]`,
+		Long:  `dagu start-all [--dags=<DAGs dir>] [--host=<host>] [--port=<port>]`,
 		PreRun: func(cmd *cobra.Command, _ []string) {
 			_ = viper.BindPFlag("port", cmd.Flags().Lookup("port"))
 			_ = viper.BindPFlag("host", cmd.Flags().Lookup("host"))
@@ -42,7 +40,6 @@ func startAllCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, _ []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Configuration load failed: %v", err)
 			}
 			logger := logger.NewLogger(logger.NewLoggerArgs{

cmd/status.go

@@ -34,7 +34,6 @@ func statusCmd() *cobra.Command {
 		Run: func(_ *cobra.Command, args []string) {
 			cfg, err := config.Load()
 			if err != nil {
-				// nolint
 				log.Fatalf("Configuration load failed: %v", err)
 			}
 			logger := logger.NewLogger(logger.NewLoggerArgs{
@@ -45,7 +44,6 @@ func statusCmd() *cobra.Command {
 			// Load the DAG file and get the current running status.
 			workflow, err := dag.Load(cfg.BaseConfig, args[0], "")
 			if err != nil {
-				// nolint
 				logger.Error("Workflow load failed", "error", err, "file", args[0])
 				os.Exit(1)
 			}
@@ -56,7 +54,6 @@ func statusCmd() *cobra.Command {
 			curStatus, err := cli.GetCurrentStatus(workflow)
 
 			if err != nil {
-				// nolint
 				logger.Error("Current status retrieval failed", "error", err)
 				os.Exit(1)
 			}

cmd/version.go

@@ -26,7 +26,6 @@ func versionCmd() *cobra.Command {
 		Short: "Display the binary version",
 		Long:  `dagu version`,
 		Run: func(_ *cobra.Command, _ []string) {
-			// nolint // forbidgo
 			println(constants.Version)
 		},
 	}

examples/foreach.yaml

@@ -0,0 +1,11 @@
+steps:
+  - name: foreach
+    foreach: "[1, 2, 3]"
+    command: sh
+    output: "foreach-$1.txt"
+    script: |
+      echo "Hello, world! $1"
+  - name: merge
+    command: sh
+    script: |
+      cat foreach-*.txt

internal/client/client_test.go

@@ -152,7 +152,6 @@ func TestClient_GetStatus(t *testing.T) {
 	})
 }
 
-// nolint // paralleltest
 func TestClient_RunDAG(t *testing.T) {
 	t.Run("RunDAG", func(t *testing.T) {
 		setup := test.SetupTest(t)

internal/dag/builder.go

@@ -82,11 +82,11 @@ var (
 	errStepCommandMustBeArrayOrString = errors.New(
 		"step command must be an array of strings or a string",
 	)
+	errInvalidParamValue    = errors.New("invalid parameter value")
 	errCallFunctionNotFound = errors.New(
 		"call must specify a functions that exists",
 	)
 	errNumberOfParamsMismatch = errors.New(
-		// nolint
 		"the number of parameters defined in the function does not match the number of parameters given",
 	)
 	errRequiredParameterNotFound = errors.New(
@@ -362,7 +362,6 @@ func (b *builder) buildMiscs() (err error) {
 // Case 2: env is an array of maps.
 // Case 3: is recommended because the order of the environment variables is
 // preserved.
-// nolint // cognitive complexity
 func loadVariables(strVariables any, opts buildOpts) (
 	map[string]string, error,
 ) {
@@ -471,7 +470,6 @@ type stepBuilder struct {
 }
 
 // buildStep builds a step from the step definition.
-// nolint // cognitive complexity
 func (b *stepBuilder) buildStep(
 	variables []string, def *stepDef, fns []*funcDef,
 ) (*Step, error) {