Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose base url and update default fetch policy API #34

Merged
merged 5 commits into from
Mar 9, 2020

Conversation

thomasdashney
Copy link
Contributor

@thomasdashney thomasdashney commented Mar 6, 2020

  • Expose Api#baseUrl (needed it for some UI work)
  • Fix a bug where Api#defaultFetchPolicy was not being used
  • Rename ApiProvider#defaultFetchPolicy prop to defaultFetchPolicies, which now takes an object*. This will future-proof it so that we can pass different default fetch policies for different hooks (ie. for mutations - Mutations #28)
  • Bump version to v0.4.2

@codeclimate
Copy link

codeclimate bot commented Mar 7, 2020

Code Climate has analyzed commit 6da60ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@thomasdashney thomasdashney changed the title Expose base url Expose base url and update default fetch policy API Mar 9, 2020
@azmenak azmenak merged commit 9d9a71d into master Mar 9, 2020
@azmenak azmenak deleted the expose-base-url branch March 9, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants