-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(design-system): FileExplorer (#15513)
* wip: cleaning up the specs list and swapping it to be a filetree * wip: refactor * wip: refactor * wip: work on refactor * chore: improve types * styling * chore: remove all references to Cypress in tree list * chore: remove all references to Cypress in tree list * extract spec list component * write some tests * correctly update state * chore: refactor * update test * make props optional * optimizations * add back search * use memo * run spec * run spec * fix a11l nav * add tests for spec list a11y nav * fix tests: * remove unused * update version Co-authored-by: Jessica Sachs <[email protected]>
- Loading branch information
1 parent
80aa82d
commit 2228c81
Showing
28 changed files
with
1,032 additions
and
653 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"watch-ignore": [ | ||
"./test/_test-output", | ||
"node_modules" | ||
], | ||
"require": "ts-node/register", | ||
"exit": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import 'regenerator-runtime/runtime' | ||
import 'cypress-real-events/support' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
npm/design-system/src/components/FileExplorer/FileExplorer.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
@use '../../index.scss' as *; | ||
|
||
.nav { | ||
user-select: none; | ||
white-space: nowrap; | ||
} | ||
|
||
.ul { | ||
margin-block-start: 0; | ||
margin-block-end: 0; | ||
margin-inline-start: 0; | ||
margin-inline-end: 0; | ||
padding-inline-start: 0; | ||
&:before { | ||
display: none; | ||
} | ||
} | ||
|
||
.li.li { | ||
padding-left: 20px; | ||
} | ||
|
||
|
||
.ul, .li { | ||
position: relative; | ||
list-style: none; | ||
font-size: $text-s; | ||
line-height: 1.6; | ||
} | ||
|
||
.a { | ||
position: relative; | ||
color: unset; | ||
text-decoration: none; | ||
display: inline-block; | ||
width: 100%; | ||
&:hover { | ||
cursor: pointer; | ||
} | ||
} | ||
|
||
.ul .ul { | ||
margin-inline-start: $text-xs; | ||
} | ||
|
||
.isSelected, .isSelected:hover { | ||
text-decoration: underline; | ||
} |
130 changes: 130 additions & 0 deletions
130
npm/design-system/src/components/FileExplorer/FileExplorer.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
import { mount } from '@cypress/react' | ||
import React from 'react' | ||
import { FileExplorer, FileComponentProps, FolderComponentProps } from './FileExplorer' | ||
import { FileNode, makeFileHierarchy, TreeNode } from './helpers/makeFileHierarchy' | ||
|
||
import styles from './FileExplorer.module.scss' | ||
|
||
const specs: Cypress.Cypress['spec'][] = [ | ||
{ | ||
relative: 'foo/bar/foo.spec.js', | ||
absolute: 'Users/code/foo/bar/foo.spec.js', | ||
name: 'foo/bar/foo.spec.js', | ||
}, | ||
{ | ||
relative: 'bar/foo.spec.tsx', | ||
absolute: 'bar/foo.spec.tsx', | ||
name: 'bar/foo.spec.tsx', | ||
}, | ||
{ | ||
relative: 'merp/map.spec.ts', | ||
absolute: 'merp/map.spec.ts', | ||
name: 'merp/map.spec.ts', | ||
}, | ||
] | ||
|
||
interface FileExplorerTestProps { | ||
clickFileStub: typeof cy.stub | ||
clickFolderStub: typeof cy.stub | ||
} | ||
|
||
function createFileExplorer (testProps: FileExplorerTestProps): React.FC { | ||
return () => { | ||
const [selectedFile, setSelectedFile] = React.useState<string>() | ||
|
||
const onFileClick = (file: FileNode) => { | ||
setSelectedFile(file.absolute) | ||
} | ||
|
||
const files = makeFileHierarchy(specs.map((spec) => spec.relative)) | ||
|
||
const FileComponent: React.FC<FileComponentProps> = (props) => { | ||
return ( | ||
<div onClick={() => { | ||
testProps.clickFileStub(props.item) | ||
props.onClick(props.item) | ||
}}> | ||
{props.item.name} | ||
</div> | ||
) | ||
} | ||
|
||
const FolderComponent: React.FC<FolderComponentProps> = (props) => { | ||
return ( | ||
<div onClick={() => { | ||
testProps.clickFolderStub() | ||
props.onClick() | ||
}}> | ||
{props.item.name} | ||
</div> | ||
) | ||
} | ||
|
||
return ( | ||
<FileExplorer | ||
files={files} | ||
cssModule={styles} | ||
selectedFile={selectedFile} | ||
fileComponent={FileComponent} | ||
folderComponent={FolderComponent} | ||
onFileClick={onFileClick} | ||
/> | ||
) | ||
} | ||
} | ||
|
||
describe('FileExplorer', () => { | ||
it('basic usage', () => { | ||
const files: TreeNode[] = [ | ||
{ | ||
type: 'folder', | ||
name: 'foo', | ||
absolute: 'foo', | ||
files: [ | ||
{ | ||
type: 'file', | ||
name: 'bar.js', | ||
absolute: 'foo/bar.js', | ||
}, | ||
], | ||
}, | ||
] | ||
|
||
const FileComponent: React.FC<FileComponentProps> = (props) => <div>{props.item.name}</div> | ||
const FolderComponent: React.FC<FolderComponentProps> = (props) => <div>{props.item.name}</div> | ||
|
||
mount( | ||
<FileExplorer | ||
files={files} | ||
selectedFile={undefined} | ||
fileComponent={FileComponent} | ||
folderComponent={FolderComponent} | ||
onFileClick={() => {}} | ||
/>, | ||
) | ||
}) | ||
|
||
it('clicks file and folders', () => { | ||
const clickFolderStub = cy.stub() | ||
const clickFileStub = cy.stub() | ||
|
||
const Wrapper = createFileExplorer({ | ||
clickFolderStub, | ||
clickFileStub, | ||
}) | ||
|
||
mount(<Wrapper />) | ||
|
||
cy.get('div').contains('bar').click().then(() => { | ||
expect(clickFolderStub).to.have.been.calledWith() | ||
}) | ||
|
||
cy.get('div').contains('map.spec.ts').click().then(() => { | ||
expect(clickFileStub).to.have.been.calledWith({ | ||
type: 'file', | ||
absolute: 'merp/map.spec.ts', | ||
name: 'map.spec.ts', | ||
}) | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.