Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend/backend): address all blocking issues #1443

Merged
merged 17 commits into from
Feb 17, 2025

Conversation

mercihabam
Copy link
Member

@mercihabam mercihabam commented Feb 10, 2025

In tandem with: https://gitlab.com/tikiwiki/tiki/-/merge_requests/6934

  • The filter component on mobile overlaps the content title
  • The Tiki bottom menu is mostly hidden from the left side
  • Errors “could not perform action…” when navigating to the info page
  • Git revision raises failed to fetch
  • Removing an imap/smtp server does not show it as deleted
  • Add an email, the label “Select an E-mail provider” is below the select element. This is also the case for the folders page
  • Adding a server does not refresh the state
  • Import accounts using yaml/csv file - Downloading a sample fails with the message “File wasn’t available on site”
  • Search page. Select filters do not occupy enough space for their content to be readable.
  • Selecting an email row from the search page, the actions component pops over the content title, making the whole thing unreadable.
  • When hitting the action “Read/Unread/Flag/Archive/Delete” the offline error is shown and the action is undone visually. This also happens when deleting a folder.
  • The refresh button on the search page does not do anything.
  • Deleting saved searches does not work
  • Saving a draft message shows the offline error
  • Listing message in the draft folder shows the offline error
  • Everything/Junk/Flagged/Sent/Snoozed/Trash/Unread view as well.
  • After performing a search in a folder, navigating between the paginated results, and then clearing the search, the pages keep the lists from the search result.
  • When filtering between read/unread/flagged/… the paginated lists do not get updated.
  • When opening an unread message, the counter does not get updated.
  • Message view - create tracker item/move to tracker does not do anything unless the window is reloaded
  • Snooze - Pick a date does not show a date picker
  • Deleting a message reloads the browser to the next message, but the prev button shows the title of the previously deleted message
  • The search page on mobile does not fully show the filter inputs
  • Server status and capabilities not shown
  • Failure when navigating to the filters page
  • A bunch of errors “Sieve: Error while trying to connect to ManageSieve” when navigating to the blocklist page (They are legitimate because they warn the user that Sieve is not authenticated).

@marclaporte
Copy link
Member

Thank you for collecting such a nice thorough list of issues in Cypht. This is getting us closer to Cypht 2.5.0

When it comes time to merge, I suppose we will not squash them, right?
https://en.m.wikipedia.org/wiki/Atomic_commit

@mercihabam
Copy link
Member Author

We can squash the commits while keeping the commit history intact, as each issue is addressed in its own commit.

@marclaporte marclaporte requested a review from kroky February 14, 2025 13:08
@marclaporte
Copy link
Member

This is big :-)

@kroky please review when it gets out of draft.

@mercihabam mercihabam marked this pull request as ready for review February 14, 2025 15:53
@mercihabam mercihabam merged commit 3c0db75 into cypht-org:master Feb 17, 2025
6 checks passed
const listPath = getParam('list_parent') || getListPathParam();
const store = new Hm_MessagesStore(listPath, Hm_Utils.get_url_page_number(), `${getParam('keyword')}_${getParam('filter')}`);
store.load();
store.removeRow(uid);
if (Hm_Utils.get_from_global('msg_uid', false)) {
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mercihabam This line and the other below should also be removed. Also remove remove_from_cached_imap_pages and check the condition above, if it is necessary then it should go after the changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants