-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend/backend): address all blocking issues #1443
Conversation
Thank you for collecting such a nice thorough list of issues in Cypht. This is getting us closer to Cypht 2.5.0 When it comes time to merge, I suppose we will not squash them, right? |
We can squash the commits while keeping the commit history intact, as each issue is addressed in its own commit. |
This is big :-) @kroky please review when it gets out of draft. |
…verriding third-party styles
…ut also to jQuery
…or deleting a folder
…ced by the update button
…e action has been performed
62bdf8b
to
1d73a94
Compare
const listPath = getParam('list_parent') || getListPathParam(); | ||
const store = new Hm_MessagesStore(listPath, Hm_Utils.get_url_page_number(), `${getParam('keyword')}_${getParam('filter')}`); | ||
store.load(); | ||
store.removeRow(uid); | ||
if (Hm_Utils.get_from_global('msg_uid', false)) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mercihabam This line and the other below should also be removed. Also remove remove_from_cached_imap_pages and check the condition above, if it is necessary then it should go after the changes. Thank you!
In tandem with: https://gitlab.com/tikiwiki/tiki/-/merge_requests/6934
A bunch of errors “Sieve: Error while trying to connect to ManageSieve” when navigating to the blocklist page(They are legitimate because they warn the user that Sieve is not authenticated).