Skip to content
This repository has been archived by the owner on Jan 17, 2025. It is now read-only.

fix: set up config during initialisation #14

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

ami-aman
Copy link
Contributor

@ami-aman ami-aman commented Jul 25, 2022

closes https://github.com/customerio/issues/issues/7791

Related to PR customerio/customerio-reactnative#15

Since the app refers the package on the npm but the updates related to config are not pushed yet so running this app with this PR might result into a crash.

Adding label Do not Merge until the config update is pushed to the npm.

@ami-oss-ci
Copy link

ami-oss-ci commented Jul 25, 2022

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@ami-aman ami-aman merged commit 8760c3b into main Jul 29, 2022
@ami-aman ami-aman deleted the aman/fix-for-config branch July 29, 2022 12:14
github-actions bot pushed a commit that referenced this pull request Jul 29, 2022
## [1.0.2](1.0.1...1.0.2) (2022-07-29)

### Bug Fixes

* set up config during initialisation ([#14](#14)) ([8760c3b](8760c3b))
@ami-ci
Copy link

ami-ci commented Jul 29, 2022

🎉 This PR is included in version 1.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants