Skip to content

BUG: check_coupling_params fails because of hard-coded sampling frequency #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctrltz opened this issue Mar 18, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@ctrltz
Copy link
Owner

ctrltz commented Mar 18, 2025

Trying to simulate 60 Hz oscillations with coupling, but the sampling frequency is set to 100 Hz in check_coupling_params:

sim.set_coupling(
    ("v1-lh", "v1-rh"), method=ppc_shifted_copy_with_noise,
    phase_lag=0, coh=1, fmin=59, fmax=61
)

As a result, filtering fails because target frequency is higher than the Nyquist one, error message:

ValueError: Digital filter critical frequencies must be 0 < Wn < 1
@ctrltz ctrltz added the bug Something isn't working label Mar 18, 2025
@ctrltz ctrltz modified the milestone: 0.0.2 Mar 25, 2025
@ctrltz
Copy link
Owner Author

ctrltz commented Mar 29, 2025

Temporary fix in 839c7d3: raised the sampling frequency to 500 Hz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant