Skip to content

FIX: rework the checks to account for accumulated problems #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
ctrltz opened this issue Mar 29, 2025 · 0 comments
Open
3 tasks

FIX: rework the checks to account for accumulated problems #78

ctrltz opened this issue Mar 29, 2025 · 0 comments
Milestone

Comments

@ctrltz
Copy link
Owner

ctrltz commented Mar 29, 2025

A bunch of issues with currently performed checks needs to be solved, potentially reconsidering the bigger picture of whether to support callables:

  • BUG: check_coupling_params fails because of hard-coded sampling frequency #74: Duration and sampling frequency of the data is currently hard-coded in checks to have some value when testing callables - we should pass sfreq and duration directly to the SourceSimulator. Also, we can think of dropping the mechanism of callables, see another problem below
  • BUG: empty patches are not handled properly #69: With callables, checks for user input are not enough - we need to double-check the result of every callable when it is called since the results of functions with randomly generated outputs might not always conform to our expectations
  • Some of the checks have overlapping functionality, e.g. check_numeric_array and check_extents
@ctrltz ctrltz added this to the 0.0.3 milestone Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant