Always use insertRule API with option link: true #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
changed the title
|
This PR seems to be ready |
|
Ok added a test with media query, its not ready, fixing it. |
HenriBeck
reviewed
Sep 16, 2018
| @@ -34,7 +31,6 @@ export default class StyleSheet { | |||
| constructor(styles: Object, options: StyleSheetOptions) { | |||
| this.attached = false | |||
| this.deployed = false | |||
| this.linked = false | |||
There was a problem hiding this comment.
Why did you remove the linked property?
There was a problem hiding this comment.
because we don't need it any more, if options.link is true, then it is always linked, there is no separate sheet.link() call.
HenriBeck
approved these changes
Sep 16, 2018
TrySound
approved these changes
Sep 16, 2018
|
Should fix (still verifying) #815, #710, #664 |
|
Looks good to me |
|
Yeah, to me too |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
Current linking logic causes too many bugs. This approach simplifies it. We are not linking any more using selector, we create rules using insertRule API always when we need to link a rule.
Corresponding issue (if exists):
Fixes #815, #710, #664