Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS deploy pipeline #408

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Conversation

mprasanjith
Copy link
Contributor

Description

  • Refactor CI / CD pipeline to deploy to IPFS / Filecoin through Web3.storage.
  • Publish preview deploys as Github Environments.
  • Add cleanup pipeline to deactivate Github Environment for closed PRs.
  • Switch to hash routing for IPFS compatibility.

Caveats

Currently IPFS does not support SPA browser routing, which means we have to switch to hash routing. A solution might be landing to IPFS in the future.

Prerequisites

This PR should not be merged until we set the WEB3_STORAGE_TOKEN secret in repo settings.

Motivation and Context

This will let us;

  • move away from Netlify / GitHub pages for dev deployments.
  • continue having preview URLs for all PRs the same way Netlify provides today.

How Has This Been Tested?

Tested from a forked Github repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fix IPFS action version.

Switch to hash routing.

Add actions to use Github Deployments API.

Update IPFS action to use Web3.Storage.

Fix start deployment step.

Refactor deploy pipeline.

Add ref to deployment.

Add dev branch deploys.

Fix deployment env reference.

Fix env reference.
@mprasanjith mprasanjith changed the title Add IPFS deploy Github Action with Pinata Add IPFS deploy pipeline Aug 13, 2021
@mprasanjith mprasanjith marked this pull request as ready for review August 13, 2021 19:34
@rossneilson
Copy link
Member

Aside from the failing build currently ... (Hopefully a small issue)
This is so cool and definitely something we should share with the rest of DXdao!
Maybe you could bring it up on the next developer call @mprasanjith

@mprasanjith
Copy link
Contributor Author

mprasanjith commented Aug 13, 2021

The build is failing due to the missing WEB3_STORAGE_TOKEN secret, so once we have that added we should be good to go.

This definitely is something we can share with other teams, let's discuss in the next Dev call.

PS: Just figured I had the wrong diagnosis for the failing build. I put the PR from a fork of this repo. That means the upstream GitHub pipeline on this repo is not able to access my fork to do the CI build. Shouldn't be a problem once merged.

@mprasanjith mprasanjith merged commit 4e85373 into cryptonative-ch:dev Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants