Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (e2e) : change nodeport service access in jkube e2e test (#4683) #4695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #4683

Relates to: #4636

Usage of unix style variables to store temporary command results isn't working on windows. Execute the same steps using golang code in order to make check platform independent.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Remove the steps involving setting/evaluating unix style variables and add a custom step to extract NodePort and crc machine ip and hit the endpoint.

Testing

I've tested it on my windows machine to verify test is still passing after making changes

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Copy link

openshift-ci bot commented Mar 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia rohanKanojia changed the title test (e2e) : change nodeport service access in jkube test (#4683) test (e2e) : change nodeport service access in jkube e2e test (#4683) Mar 24, 2025
Usage of unix style variables to store temporary command results
isn't working on windows. Execute the same steps using golang code
in order to make it work on windows.

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia marked this pull request as ready for review March 25, 2025 05:22
@openshift-ci openshift-ci bot requested review from adrianriobo and gbraad March 25, 2025 05:22
@praveenkumar
Copy link
Member

@lilyLuLiu can you test it on windows now if it still have issue because CI is not working.

@lilyLuLiu
Copy link
Contributor

Tested on windows and mac, all passed.
The pr check on linux-arm64 also passed.
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QE] e2e test deploy JKube fail on Windows
3 participants