Use virtio-net device for forwarding networking data between the guest and host #4682
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vyasgun
force-pushed
the
pr/use-virtio-net
branch
3 times, most recently
from
7349709 to
844e8ba
Compare
pkg/drivers/vfkit/driver_darwin.go
Outdated
| @@ -246,12 +246,12 @@ func (d *Driver) Start() error { | |||
| return err | |||
| } | |||
|
|
|||
| // virtio-vsock device | |||
| dev, err = config.VirtioVsockNew(d.DaemonVsockPort, d.VsockPath, true) | |||
| netDev, err := config.VirtioNetNew("5a:94:ef:e4:0c:ee") | |||
There was a problem hiding this comment.
This duplicates a value from cmd/crc/cmd/daemon.go, this at least deserves a comment, probably best to add it to d.
There was a problem hiding this comment.
I'd add the UnixgramSocketPath to driver to be similar to DaemonVsockPort and VsockPath.
Maybe we can even support both vsock and unixgram modes in driver_darwin.go depending on which values are set in d?
There was a problem hiding this comment.
I have added code to set vsock mode only if UnixgramSockPath is not set but I'm setting the path here:
https://github.com/crc-org/crc/pull/4682/files#diff-bd1e0081558a01b12d1bfbb4eedac6696b0f7bc6571e2637d6207a9f7779e38bR70
so it won't be empty
vyasgun
force-pushed
the
pr/use-virtio-net
branch
from
844e8ba to
3dfa9cb
Compare
vyasgun
force-pushed
the
pr/use-virtio-net
branch
from
ada685b to
1be0233
Compare
vyasgun
force-pushed
the
pr/use-virtio-net
branch
from
1be0233 to
85b83f1
Compare
Description
Use virtio-net device for forwarding networking data between the guest and host
Fixes: #4460
Type of change
test, version modification, documentation, etc.)
Proposed changes
Testing
Contribution Checklist