test: microshift: Don't force network-mode to 'user' #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
@jsliacan Can you try that and see if that works as expected. |
We want our testing to be as close as possible to what end-users will experience. Changing `network-mode` is a significant difference from the default. `user` is now the default so we don’t need to explicitly set it.
…latform" This reverts commit 557ec94. We no longer set network-mode as part of the tests, so this code is not needed.
cfergeau
force-pushed
the
e2e-microshift
branch
from
9bae8e5 to
12c5074
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
With the switch to user-mode networking everywhere, this probably can go in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filing this now so that we don't forget it when we have bundles with crc-org/snc#797. This will be put on hold until this happens.
We want our testing to be as close as possible to what end-users will
experience. Changing
network-modeis a significant difference from thedefault. With crc-org/snc#797 fixed, we no longer
need to force it to
user.