Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use text rather than string for tokenIds field type #52

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

alfetopito
Copy link
Contributor

Summary

While locally there are no issues, inserting long values into tokenIds field causes the operation to fail
image

The max char length of the string field is 255, while the text field has no limits.

@alfetopito alfetopito self-assigned this Feb 11, 2025
@alfetopito alfetopito requested a review from a team February 11, 2025 18:32
@alfetopito
Copy link
Contributor Author

Deployed using pulumi, tested by pointing the GH action there and it worked! https://github.com/cowprotocol/stablecoins-tracker/actions/runs/13270139413/job/37047391484

Merging

@alfetopito alfetopito merged commit 14536e2 into main Feb 11, 2025
3 checks passed
@alfetopito alfetopito deleted the feat/fix-text-length branch February 12, 2025 07:48
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

Anyways, this tax-free stuff is now unused, right? we could technically remove @shoom3301 ?

@alfetopito
Copy link
Contributor Author

👍 good

Anyways, this tax-free stuff is now unused, right? we could technically remove @shoom3301 ?

Yes, the whole model can be removed.
I did not do this sooner as we'd need to deploy the new version first.
Also, better to wait awhile to remove the previous types as older UI versions might misbehave if this is removed.

@anxolin
Copy link
Contributor

anxolin commented Mar 10, 2025

Yes, the whole model can be removed.
I did not do this sooner as we'd need to deploy the new version first.
Also, better to wait awhile to remove the previous types as older UI versions might misbehave if this is removed.

Makes sense to delay the deletion then.
Regarding the "we'd need to deploy the new version first.", I think the new version is live for some time already

@alfetopito
Copy link
Contributor Author

Yes, the whole model can be removed.
I did not do this sooner as we'd need to deploy the new version first.
Also, better to wait awhile to remove the previous types as older UI versions might misbehave if this is removed.

Makes sense to delay the deletion then. Regarding the "we'd need to deploy the new version first.", I think the new version is live for some time already

Done: #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants