Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update solver models to include vouching, whitelisting, and service fee #49

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

bram-vdberg
Copy link
Contributor

@bram-vdberg bram-vdberg commented Jan 30, 2025

This PR extends #48 to include both whitelisting and vouching information on the solver-network relation. It also updates the solver-bonding-pool relation to indicate whether it is a full bonding pool or a reduced bonding pool and updates the solver model to indicate whether or not the solver pays a service fee.

It also adds flags to the solver-network and solver models to indicate whether a solver is colocated and whether a solver's address is colocated.

image
image
image

@bram-vdberg bram-vdberg requested a review from harisang January 30, 2025 13:54
@bram-vdberg bram-vdberg marked this pull request as ready for review January 30, 2025 13:56
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Just some minor comments.

Also, not from this PR, but I didn't get why this relationship allows more than one solver to the same "Solver bonding pool". I would think you want to limit it to one solver. This way, yes multiple solvers can stil belong to many bonding pool, but you really keep track of the joining joinOn date you have in this relation entity.

Otherwise, you will have two options to add a new solver to a pool:

  • Edit "Solver Bonding Pool" and add it to the list of solvers
  • Add a new "Solver Bonding Pool" and map it to the same "Bonding pool"

Does it make sense?

image

@bram-vdberg
Copy link
Contributor Author

Great!

Just some minor comments.

Also, not from this PR, but I didn't get why this relationship allows more than one solver to the same "Solver bonding pool". I would think you want to limit it to one solver. This way, yes multiple solvers can stil belong to many bonding pool, but you really keep track of the joining joinOn date you have in this relation entity.

Otherwise, you will have two options to add a new solver to a pool:

* Edit "Solver Bonding Pool" and add it to the list of solvers

* Add a new "Solver Bonding Pool" and map it to the same "Bonding pool"

Does it make sense?
image

Thanks, I think this makes sense. At the moment we only update the solver-bonding-pool relationship and I don't think we use the bonding-pool one. I'll set up a PR for that.

@bram-vdberg bram-vdberg requested a review from anxolin January 31, 2025 10:32
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged and deployed? I'm commander this week, I could help with this

Approving since you are the one that knows best the model, but my understanding is that 1 solver belongs to only one pool, so probably you want to reflect that in the model. right now its a N:M relationship so you can geet a lot of bonding pools for the same solver

@bram-vdberg
Copy link
Contributor Author

Should this be merged and deployed? I'm commander this week, I could help with this

Approving since you are the one that knows best the model, but my understanding is that 1 solver belongs to only one pool, so probably you want to reflect that in the model. right now its a N:M relationship so you can geet a lot of bonding pools for the same solver

Thanks, we should look at restructuring this part a bit in a follow-up PR since it's a bit hard to represent. For example, if a solver set's up a reduced bonding pool then in a way they're in both the CoW bonding pool and the reduced bonding pool.

@bram-vdberg bram-vdberg merged commit 996470e into main Feb 27, 2025
3 checks passed
@bram-vdberg bram-vdberg deleted the Update-Solver-Flags branch February 27, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants