Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

deps: upgradingto ibc-go v6-alpha1 #139

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

damiannolan
Copy link

@damiannolan damiannolan commented Oct 6, 2022

Summary

  • Upgrading ibc-go to v6.0.0-alpha1
  • Adding ibc-go/v6 upgrade handler to app
  • Removing claiming on channel capability in intertx handshake callback OnChanOpenInit
  • Removing lookup of channel capability in intertx/SubmitTx handler

Follow up tasks:

  • Cut release/0.4.x branch for ibc-go/v6 line
  • Tag v0.4.0 and build docker image

@@ -728,7 +709,7 @@ func (app *App) GetBaseApp() *baseapp.BaseApp {
}

// GetStakingKeeper implements the TestingApp interface.
func (app *App) GetStakingKeeper() ibctestingtypes.StakingKeeper {
func (app *App) GetStakingKeeper() stakingkeeper.Keeper {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -157,18 +149,6 @@ func (im IBCModule) OnTimeoutPacket(
return nil
}

// NegotiateAppVersion implements the IBCModule interface
func (im IBCModule) NegotiateAppVersion(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code

@damiannolan damiannolan merged commit 3dbc8dc into master Oct 10, 2022
@crodriguezvega crodriguezvega deleted the damian/upgrade-to-v6-alpha1 branch January 29, 2023 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants