Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly set channel version for non-incentivized ica tests #2036

Merged
merged 3 commits into from
Aug 19, 2022
Merged

chore: explicitly set channel version for non-incentivized ica tests #2036

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1773e2b
explicitly set channel version for non-incentivized ica tests
damiannolan Aug 18, 2022
ed3cffe
chore: updating tag in manual e2e icad workflow
chatton Aug 18, 2022
bd87bc1
Merge branch 'main' into damian/explicit-version-string
damiannolan Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e-manual-icad.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
- master
- v0.3.2
- v0.2.2
- v0.1.2
- v0.1.3
chain-b-tag:
default: master
description: 'The tag to use for chain B'
Expand All @@ -35,7 +35,7 @@ on:
- master
- v0.3.2
- v0.2.2
- v0.1.2
- v0.1.3
relayer-tag:
description: 'The tag to use for the relayer'
required: true
Expand Down
5 changes: 3 additions & 2 deletions e2e/interchain_accounts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/cosmos/ibc-go/e2e/testsuite"
"github.com/cosmos/ibc-go/e2e/testvalues"

icatypes "github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/types"
feetypes "github.com/cosmos/ibc-go/v5/modules/apps/29-fee/types"
ibctesting "github.com/cosmos/ibc-go/v5/testing"
)
Expand Down Expand Up @@ -90,7 +91,7 @@ func (s *InterchainAccountsTestSuite) TestMsgSubmitTx_SuccessfulTransfer() {
var hostAccount string

t.Run("register interchain account", func(t *testing.T) {
version := "" // allow app to handle the version as appropriate.
version := icatypes.NewDefaultMetadataString(ibctesting.FirstConnectionID, ibctesting.FirstConnectionID)
msgRegisterAccount := intertxtypes.NewMsgRegisterAccount(controllerAccount.Bech32Address(chainA.Config().Bech32Prefix), ibctesting.FirstConnectionID, version)
err := s.RegisterInterchainAccount(ctx, chainA, controllerAccount, msgRegisterAccount)
s.Require().NoError(err)
Expand Down Expand Up @@ -184,7 +185,7 @@ func (s *InterchainAccountsTestSuite) TestMsgSubmitTx_FailedTransfer_Insufficien
var hostAccount string

t.Run("register interchain account", func(t *testing.T) {
version := "" // allow app to handle the version as appropriate.
version := icatypes.NewDefaultMetadataString(ibctesting.FirstConnectionID, ibctesting.FirstConnectionID)
msgRegisterAccount := intertxtypes.NewMsgRegisterAccount(controllerAccount.Bech32Address(chainA.Config().Bech32Prefix), ibctesting.FirstConnectionID, version)
err := s.RegisterInterchainAccount(ctx, chainA, controllerAccount, msgRegisterAccount)
s.Require().NoError(err)
Expand Down