Set proper default command output

client/flags/flags.go

@@ -88,9 +88,6 @@ func AddQueryFlagsToCmd(cmd *cobra.Command) {
 	cmd.Flags().StringP(tmcli.OutputFlag, "o", "text", "Output format (text|json)")
 
 	cmd.MarkFlagRequired(FlagChainID)
-
-	cmd.SetErr(cmd.ErrOrStderr())
-	cmd.SetOut(cmd.OutOrStdout())
 }
 
 // AddTxFlagsToCmd adds common flags to a module tx command.
@@ -119,9 +116,6 @@ func AddTxFlagsToCmd(cmd *cobra.Command) {
 	cmd.Flags().String(FlagGas, "", fmt.Sprintf("gas limit to set per-transaction; set to %q to calculate sufficient gas automatically (default %d)", GasFlagAuto, DefaultGasLimit))
 
 	cmd.MarkFlagRequired(FlagChainID)
-
-	cmd.SetErr(cmd.ErrOrStderr())
-	cmd.SetOut(cmd.OutOrStdout())
 }
 
 // AddPaginationFlagsToCmd adds common pagination flags to cmd

client/keys/add.go

@@ -77,9 +77,6 @@ the flag --nosort is set.
 	cmd.Flags().Uint32(flagIndex, 0, "Address index number for HD derivation")
 	cmd.Flags().String(flags.FlagKeyAlgorithm, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for")
 
-	cmd.SetOut(cmd.OutOrStdout())
-	cmd.SetErr(cmd.ErrOrStderr())
-
 	return cmd
 }
 

client/keys/list.go

@@ -34,8 +34,6 @@ func runListCmd(cmd *cobra.Command, _ []string) error {
 		return err
 	}
 
-	cmd.SetOut(cmd.OutOrStdout())
-
 	if ok, _ := cmd.Flags().GetBool(flagListNames); !ok {
 		output, _ := cmd.Flags().GetString(cli.OutputFlag)
 		printInfos(cmd.OutOrStdout(), infos, output)

server/export.go

@@ -109,8 +109,7 @@ func ExportCmd(appExporter types.AppExporter, defaultNodeHome string) *cobra.Com
 			return nil
 		},
 	}
-	cmd.SetOut(cmd.OutOrStdout())
-	cmd.SetErr(cmd.ErrOrStderr())
+
 	cmd.Flags().String(flags.FlagHome, defaultNodeHome, "The application home directory")
 	cmd.Flags().Int64(FlagHeight, -1, "Export state from a particular height (-1 means latest height)")
 	cmd.Flags().Bool(FlagForZeroHeight, false, "Export state to start at height zero (perform preproccessing)")

simapp/simd/cmd/root.go

@@ -83,6 +83,12 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) {
 	a := appCreator{encodingConfig}
 	server.AddCommands(rootCmd, simapp.DefaultNodeHome, a.newApp, a.appExport, addModuleInitFlags)
 
+	// set the default command output properly
+	rootCmd.PersistentPreRun = func(cmd *cobra.Command, args []string) {
+		cmd.SetOut(cmd.OutOrStdout())
+		cmd.SetErr(cmd.ErrOrStderr())
+	}
+
 	// add keybase, auxiliary RPC, query, and tx child commands
 	rootCmd.AddCommand(
 		rpc.StatusCommand(),

version/command.go

@@ -17,7 +17,6 @@ func NewVersionCommand() *cobra.Command {
 		Short: "Print the application binary version information",
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			verInfo := NewInfo()
-			cmd.SetOut(cmd.OutOrStdout())
 
 			if long, _ := cmd.Flags().GetBool(flagLong); !long {
 				cmd.Println(verInfo.Version)

x/auth/client/cli/tx_sign.go

@@ -143,7 +143,6 @@ func makeSignBatchCmd() func(cmd *cobra.Command, args []string) error {
 func setOutputFile(cmd *cobra.Command) (func(), error) {
 	outputDoc, _ := cmd.Flags().GetString(flags.FlagOutputDocument)
 	if outputDoc == "" {
-		cmd.SetOut(cmd.OutOrStdout())
 		return func() {}, nil
 	}