x/{gov,params,upgrade,distribution} CLI: In-Process test & use grpc query service #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
added
C:CLI
C:x/gov
C:x/distribution
Codecov Report
@@ Coverage Diff @@
## master #6664 +/- ##
==========================================
- Coverage 60.25% 60.22% -0.03%
==========================================
Files 512 511 -1
Lines 31502 31532 +30
==========================================
+ Hits 18982 18991 +9
- Misses 11073 11105 +32
+ Partials 1447 1436 -11 |
9 tasks
amaury1093
changed the title
This was referenced Jul 10, 2020
amaury1093
changed the title
|
This pull request introduces 1 alert when merging 439990e into ebc3ad6 - view on LGTM.com new alerts:
|
amaury1093
force-pushed
the
am-cli-params-distrib
branch
from
7a00771 to
ac7790c
Compare
amaury1093
commented
Jul 16, 2020
amaury1093
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
approved these changes
Jul 20, 2020
fedekunze
added
the
A:automerge
aaronc
approved these changes
Jul 20, 2020
| ValidatorAddress: validatorAddr, | ||
| StartingHeight: startHeight, | ||
| EndingHeight: endHeight, | ||
| Req: pageReq, |
There was a problem hiding this comment.
I didn't catch this before but page parameters should not be called req. I would just use page or something like that. This can be fixed separate from this PR but it should be addressed before release. /cc @sahith-narahari @anilcse @atheeshp
| ProposalStatus: proposalStatus, | ||
| Voter: voterAddr, | ||
| Depositor: depositorAddr, | ||
| Req: pageReq, |
|
|
||
| res, err := queryClient.Votes( | ||
| context.Background(), | ||
| &types.QueryVotesRequest{ProposalId: proposalID, Req: pageReq}, |
9 tasks
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
…uery service (cosmos#6664) * refactor CLI to use grpc query service * In process CLI for gov * ReadQueryCommandFlags * gov tx * Fix compiler errors * Formatting * x/distribution: use gRPC query * Consistent * Fix x/distrib test * Update x/gov * Add ReadQueryCommandFlags * Fix lint * Revert x/params * x/params use grpc query * Fix tests * Use page request Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring CLI for in-process testing, and use gRPC query service in CLI.
TODO:
ref:
In-process Testing:
CLI to use grpc query service:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes