Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append dracut-random.cpio.gz in the compression format of the initrd #4702

Conversation

ericcurtin
Copy link
Contributor

@ericcurtin ericcurtin commented Nov 28, 2023

Appending this file assumed the initrd was built assuming gzip compression format, sometimes other compression formats are used because of boot speed or other desireable qualities.

Appending this file assumed the initrd was built assuming gzip
compression format, sometimes other compression formats are used
because of boot speed or other desireable qualities.

Signed-off-by: Eric Curtin <[email protected]>
Copy link

openshift-ci bot commented Nov 28, 2023

Hi @ericcurtin. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericcurtin ericcurtin marked this pull request as draft November 28, 2023 19:39
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.

bin="$(/usr/lib/dracut/skipcpio "$image" | { read -r -N 6 bin && echo "$bin"; })"

Check warning

Code scanning / shellcheck

image is referenced but not assigned.

image is referenced but not assigned.
@cgwalters
Copy link
Member

Closing in favor of #4705

@cgwalters cgwalters closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants