-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force use of iptables on Windows WSL #25202
Force use of iptables on Windows WSL #25202
Conversation
@@ -12,6 +12,9 @@ const containersConf = `[containers] | |||
[engine] | |||
cgroup_manager = "cgroupfs" | |||
[network] | |||
firewall_driver="iptables" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the issue link as comment here so we know why this is set right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have fixed it.
This is a workaround for containers#25201 and helps with upgrading the WSL image to Fedora 41. Signed-off-by: Mario Loriedo <[email protected]>
ee931c8
to
dae1541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should pick this into 5.4 so we can update the fedora base image for it.
Setting label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, l0rd, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This is a workaround for #25201 and helps with
upgrading the WSL image to Fedora 41.
Does this PR introduce a user-facing change?