Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce React Testing Library config #32

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Introduce React Testing Library config #32

merged 2 commits into from
Jan 1, 2025

Conversation

Tlacenka
Copy link
Collaborator

In this PR I introduce React Testing Library config based on the official plugin.

Notable changes

  • I added query preferences for matchers.
  • I had to reduce the severity of multiple rules as the error level was overused and inconsistent with type.
  • I introduced a helper for transforming kebab-case to camelCase for the lint utils to correctly name imported variable.

@Tlacenka Tlacenka requested a review from matejchalk December 31, 2024 17:38
@Tlacenka Tlacenka self-assigned this Dec 31, 2024
matejchalk
matejchalk approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

@Tlacenka Tlacenka requested a review from matejchalk December 31, 2024 18:32
@Tlacenka Tlacenka merged commit 825d63b into code-pushup:main Jan 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@Tlacenka Tlacenka

Labels
🧩 eslint-config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlacenka @matejchalk