Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): add find in file logic #978

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

BioPhoton
Copy link
Collaborator

This PR includes:

  • findInFile - pattern matching in files streamsd for scale and align with the models type SourceFileLocation
  • tests

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit cee16bc with previous commit c677fa2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 50 ↓ −3.6
Code style 🟢 100 🟢 99 ↓ −0.4
Code coverage 🟢 91 🟢 91 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
👍 1 group improved, 👎 3 groups regressed, 👍 2 audits improved, 👎 11 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 50 ↓ −3.6
ESLint Suggestions 🟢 100 🟢 99 ↓ −0.4
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 300 ms 🟥 Root document took 960 ms ↑ +215.1 %
ESLint Prefer using the String.raw tag to avoid escaping \. 🟩 passed 🟥 1 warning ↑ +∞ %
Lighthouse Speed Index 🟨 4.8 s 🟥 6.2 s ↑ +30.8 %
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.7 s ↑ +3.8 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.7 s ↓ −1 %
Lighthouse Total Blocking Time 🟥 2,800 ms 🟥 3,380 ms ↑ +20.7 %
Lighthouse Time to Interactive 🟥 13.6 s 🟥 13.8 s ↑ +1.4 %
JSDoc coverage Functions coverage 🟥 451 undocumented functions 🟥 451 undocumented functions  +0 %
Code coverage Function coverage 🟩 93 % 🟩 92.9 % ↓ −0.1 %
JSDoc coverage Types coverage 🟥 210 undocumented types 🟥 212 undocumented types ↑ +1 %
Code coverage Line coverage 🟨 90 % 🟨 89.9 % ↓ −0.1 %
Code coverage Branch coverage 🟨 85.9 % 🟨 85.9 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 203 undocumented variables 🟥 206 undocumented variables ↑ +1.5 %
Lighthouse Minimizes main-thread work 🟥 11.3 s 🟥 13.6 s ↑ +20.6 %
Lighthouse JavaScript execution time 🟥 6.3 s 🟥 7.0 s ↑ +11 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↓ −32.6 %
Lighthouse Max Potential First Input Delay 🟥 1,930 ms 🟥 1,820 ms ↓ −5.3 %
Lighthouse Server Backend Latencies 🟩 170 ms 🟩 110 ms ↓ −34.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,829 KiB 🟩 Total size was 1,829 KiB ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 920 ms 🟥 Potential savings of 950 ms ↑ +2.3 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −1.9 %

573 other audits are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant