Serialise origin bucket modifications #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't modify an S3 bucket's policy & public access block at the same time, AWS API will complain: OperationAborted: A conflicting conditional operation is currently in progress against this resource Serialise operations to the origin bucket so we don't run into this error. The suggested fix is from hashicorp/terraform-provider-aws#7628
alexjurkiewicz
requested review from
Gowiem and
joe-niland
and removed request for
a team
|
/test all |
joe-niland
reviewed
Mar 9, 2021
main.tf
Outdated
| @@ -94,7 +94,7 @@ data "template_file" "default" { | |||
|
|
|||
| resource "aws_s3_bucket_policy" "default" { | |||
| count = ! local.using_existing_origin || var.override_origin_bucket_policy ? 1 : 0 | |||
| bucket = local.bucket | |||
| bucket = aws_s3_bucket.origin.bucket | |||
There was a problem hiding this comment.
Suggested change
| bucket = aws_s3_bucket.origin.bucket | |
| bucket = join("", aws_s3_bucket.origin.*.bucket) |
joe-niland
previously requested changes
Mar 9, 2021
|
Thank you! Fixed
…On Wed, 10 Mar 2021 at 08:47, Joe Niland ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@alexjurkiewicz <https://github.com/alexjurkiewicz> just a small typo to
fix
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4U5LLPQY6GUM5KOFCEVTTC2JOBANCNFSM4YYRRGNA>
.
|
mergify
bot
dismissed
joe-niland’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
/test bats |
|
/test readme |
|
/test terratest |
joe-niland
approved these changes
Mar 10, 2021
|
Thank you @alexjurkiewicz ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't modify an S3 bucket's policy & public access block at the same
time, AWS API will complain:
OperationAborted: A conflicting conditional operation is currently in progress against this resource
This error can appear during both deploy and destroy for the module.
Serialise operations to the origin bucket so we don't run into this
error. The suggested fix is from
hashicorp/terraform-provider-aws#7628
references
Fixes #104