Fixup the exports in node:stream/web (#1873)

cloudflare · Mar 21, 2024 · 4e768b5 · 4e768b5
1 parent 371a876
commit 4e768b5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 19 deletions.
diff --git a/src/node/stream/web.js b/src/node/stream/web.js
@@ -3,25 +3,24 @@
 //     https://opensource.org/licenses/Apache-2.0
 //
 /* eslint-disable */
-export {
-  ReadableStream,
-  ReadableStreamDefaultReader,
-  ReadableStreamBYOBReader,
-  ReadableStreamBYOBRequest,
-  ReadableByteStreamController,
-  ReadableStreamDefaultController,
-  TransformStream,
-  TransformStreamDefaultController,
-  WritableStream,
-  WritableStreamDefaultWriter,
-  WritableStreamDefaultController,
-  ByteLengthQueuingStrategy,
-  CountQueuingStrategy,
-  TextEncoderStream,
-  TextDecoderStream,
-  CompressionStream,
-  DecompressionStream,
-}
+
+export const ReadableStream = globalThis.ReadableStream;
+export const ReadableStreamDefaultReader = globalThis.ReadableStreamDefaultReader;
+export const ReadableStreamBYOBReader = globalThis.ReadableStreamBYOBReader;
+export const ReadableStreamBYOBRequest = globalThis.ReadableStreamBYOBRequest;
+export const ReadableByteStreamController = globalThis.ReadableByteStreamController;
+export const ReadableStreamDefaultController = globalThis.ReadableStreamDefaultController;
+export const TransformStream = globalThis.TransformStream;
+export const TransformStreamDefaultController = globalThis.TransformStreamDefaultController;
+export const WritableStream = globalThis.WritableStream;
+export const WritableStreamDefaultWriter = globalThis.WritableStreamDefaultWriter;
+export const WritableStreamDefaultController = globalThis.WritableStreamDefaultController;
+export const ByteLengthQueuingStrategy = globalThis.ByteLengthQueuingStrategy;
+export const CountQueuingStrategy = globalThis.CountQueuingStrategy;
+export const TextEncoderStream = globalThis.TextEncoderStream;
+export const TextDecoderStream = globalThis.TextDecoderStream;
+export const CompressionStream = globalThis.CompressionStream;
+export const DecompressionStream = globalThis.DecompressionStream;
 
 export default {
   ReadableStream,

diff --git a/src/workerd/api/node/streams-test.js b/src/workerd/api/node/streams-test.js
@@ -38,6 +38,11 @@ import {
   promises,
 } from 'node:stream';
 
+import {
+  ByteLengthQueuingStrategy,
+} from 'node:stream/web';
+strictEqual(ByteLengthQueuingStrategy, globalThis.ByteLengthQueuingStrategy);
+
 import {
   EventEmitter,
 } from 'node:events';