Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Triton integration #2

Merged
merged 16 commits into from
Sep 9, 2024
Merged

feat: Triton integration #2

merged 16 commits into from
Sep 9, 2024

Conversation

xWiiLLz
Copy link
Contributor

@xWiiLLz xWiiLLz commented Sep 9, 2024 •
edited
Loading

This PR brings in all the changes needed for using the triton inference server.

We are currently missing the following details:

  • What to display when we get an error from either the query or assistant calls?
  • Empty state when we get no results back from the query endpoint
  • No highlight in a given hit for the hit display (under the search bar)
  • No highlight in a given hit for the article-drawer (to the right)

@xWiiLLz xWiiLLz requested a review from etiennecl September 9, 2024 14:43
etiennecl
etiennecl approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@etiennecl etiennecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline

@xWiiLLz xWiiLLz merged commit 739e404 into main Sep 9, 2024
2 checks passed
@xWiiLLz xWiiLLz deleted the feat/tritton-integration branch September 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennecl etiennecl etiennecl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xWiiLLz @etiennecl