-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuread_application attribute application_id has been deprecated #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to the following update in version 2.45.0 of hashicorp/terraform-provider-azuread, as per hashicorp/terraform-provider-azuread#1214 > `azuread_application` - export the client_id attribute, > deprecate the `application_id` attribute The `terraform validate` also issues the following warning for version 7.2.1 of this module: ``` │ Warning: Deprecated attribute │ │ on .terraform/modules/sp/outputs.tf line 8, in output "sp_app_id": │ 8: value = azuread_application.aad_app.application_id │ │ The attribute "application_id" is deprecated. Refer to the provider documentation for details. ```
BzSpi
previously requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution.
Please bump the provider version to 2.44 in the versions.tf
file.
Shr3ps
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the CHANGELOG file?
Shr3ps
approved these changes
Nov 17, 2023
jmapro
approved these changes
Nov 17, 2023
maxpoullain
approved these changes
Nov 17, 2023
zfiel
approved these changes
Nov 17, 2023
Thanks! |
Shr3ps
added a commit
that referenced
this pull request
Mar 15, 2024
…attribute instead of deprecated `application_id`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes proposed in this pull request
Follow-up to the following update in version 2.45.0 of hashicorp/terraform-provider-azuread,
as per hashicorp/terraform-provider-azuread#1214
The
terraform validate
also issues the following warning for version 7.2.1 of this module:@claranet/fr-azure-reviewers