Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application attribute application_id has been deprecated #1

Merged
merged 2 commits into from
Nov 17, 2023
Merged

azuread_application attribute application_id has been deprecated #1

merged 2 commits into from
Nov 17, 2023

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Nov 15, 2023

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes proposed in this pull request

Follow-up to the following update in version 2.45.0 of hashicorp/terraform-provider-azuread,
as per hashicorp/terraform-provider-azuread#1214

azuread_application - export the client_id attribute,
deprecate the application_id attribute

The terraform validate also issues the following warning for version 7.2.1 of this module:

│ Warning: Deprecated attribute
│
│   on .terraform/modules/sp/outputs.tf line 8, in output "sp_app_id":
│    8:   value       = azuread_application.aad_app.application_id
│
│ The attribute "application_id" is deprecated. Refer to the provider documentation for details.

@claranet/fr-azure-reviewers

Follow-up to the following update in version 2.45.0 of
hashicorp/terraform-provider-azuread,
as per hashicorp/terraform-provider-azuread#1214

> `azuread_application` - export the client_id attribute,
> deprecate the `application_id` attribute

The `terraform validate` also issues the following warning for
version 7.2.1 of this module:

```
│ Warning: Deprecated attribute
│
│   on .terraform/modules/sp/outputs.tf line 8, in output "sp_app_id":
│    8:   value       = azuread_application.aad_app.application_id
│
│ The attribute "application_id" is deprecated. Refer to the provider documentation for details.
```
BzSpi
BzSpi previously requested changes Nov 16, 2023
Copy link
Contributor

@BzSpi BzSpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.

Please bump the provider version to 2.44 in the versions.tf file.

Copy link
Member

@Shr3ps Shr3ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the CHANGELOG file?

@Shr3ps Shr3ps requested a review from BzSpi November 17, 2023 10:21
@Shr3ps Shr3ps merged commit 2aa368c into claranet:master Nov 17, 2023
Shr3ps added a commit that referenced this pull request Nov 17, 2023
Changed
  * [GH-1](#1): `azuread_application` attribute `application_id` has been deprecated.
@mloskot mloskot deleted the patch-1 branch November 17, 2023 12:08
@mloskot
Copy link
Contributor Author

mloskot commented Nov 17, 2023

Thanks!

Shr3ps added a commit that referenced this pull request Mar 15, 2024
…attribute instead of deprecated `application_id`
Shr3ps added a commit that referenced this pull request Mar 15, 2024
GH-1: fix also `azuread_service_principal` resource with `client_id` attribute...

Closes GH-1

See merge request claranet/projects/cloud/azure/terraform/modules/service-principal!9
Shr3ps added a commit that referenced this pull request Mar 15, 2024
Fixed
 * [GH-1](#1): fix also `azuread_service_principal` resource with `client_id` attribute instead of deprecated `application_id`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants