Fix for failing tests on Edge 16+ #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR was closed due to my merge messup in #968 (comment) So we'll have to create a new PR and cherry-pick @msamsel commit. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
fix tests
This PR contains
What changes did you make?
Notes:
I've tried to find out where is the problem with this test, unfortunately without any clear result.
From some unknown reason
resumemethod wasn't execute properly.https://github.com/ckeditor/ckeditor-dev/blob/96bf4037cb3ff812fc9b993bce4a304a884f361a/tests/plugins/tableselection/integrations/clipboard/pasteflow.js#L34-L44
I've tried to delay it by some timeout, but without proper reaction.
I also noticed that, when Edge starts to fail, then selection in editor disappears (became collapsed). I test also possibility to change way how selection is made with switching
bot.setHtmlWithSelectionintobender.tools.selection.setWithHtml, but second method doesn't support multiple ranges.https://github.com/ckeditor/ckeditor-dev/blob/96bf4037cb3ff812fc9b993bce4a304a884f361a/tests/plugins/tableselection/integrations/clipboard/pasteflow.js#L27
So to prevent of possible future fails, I've redesign test to run in separate editors. What fix the issue.
Blocked by: #962
Close: #1047