Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circleci template yml installs terraform-docs #624

Closed
wants to merge 1 commit into from

Conversation

katyho
Copy link

@katyho katyho commented Mar 29, 2022

Summary

A description of changes or issues addressed by this PR. Provide links to relevant PRs if any.
#619

$GITHUB_PATH is a github actions specific env var and doesn't work for circleci. Fix by just adding it to the path

Test Plan

Say unittests, or list out steps to verify changes.
Confirm that it works by manually editing my circleci config in https://github.com/FB-PLP/terraform-infra-management/pull/1681

References

(Optional) Additional links to provide more context.

@katyho katyho requested a review from a team as a code owner March 29, 2022 16:17
@katyho katyho marked this pull request as draft March 29, 2022 16:19
@edulop91 edulop91 changed the title Fix circleci template yml to install terraform-docs fix: circleci template yml installs terraform-docs Mar 29, 2022
@katyho katyho closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant