feat: warning about folders public links #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodcoffani
commented
Mar 14, 2025
rodcoffani
commented
- warning (text or modal) triggered when creating an Editor link for a folder
- add a maxDate property on oc-datepicker component
- set default expiration dates for Editor links on folders
diocas
requested changes
Mar 14, 2025
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
Outdated
Show resolved
Hide resolved
- folders expiration date defined in capability store - if the expiration is set for more than the maximum defined, is updated - removes the option to unset expiration dates for RW folders
- only for folders with RW permissions - modal or div, based on if it was created or updated - alert message defined in config store by language - check if message exists before showing
rodcoffani
force-pushed
the
feat/warning-rw-links
branch
from
f09e172 to
0fe0b30
Compare
|
the capability store still needs to be updated in the backend |
diocas
pushed a commit
that referenced
this pull request
Mar 31, 2025
chore(deps): update babel monorepo to v7.26.9
diocas
requested changes
Apr 1, 2025
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/EditDropdown.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/EditDropdown.vue
Outdated
Show resolved
Hide resolved
| @@ -40,7 +42,7 @@ export const useFileActionsCreateLink = ({ | |||
| }: { | |||
| result: PromiseSettledResult<LinkShare>[] | |||
| password?: string | |||
| options?: { copyPassword?: boolean } | |||
| options?: { isRW?: boolean; isFolder?: boolean; copyPassword?: boolean } | |||
There was a problem hiding this comment.
Isn't this info available in result? If at least one is folder and rw, then show the warning.
There was a problem hiding this comment.
The isRW can be replaced by result[0].value.type === 'edit', but there is no information about the file type in the result.
rodcoffani
force-pushed
the
feat/warning-rw-links
branch
from
888f4ef to
a598d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.