Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): auto-approve labelling conditional statement always runs true #1574

Closed
wants to merge 98 commits into from
Closed

fix(workflows): auto-approve labelling conditional statement always runs true #1574

Changes from 2 commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
fc7cb1d
try removing curly braces from conditional statement
sumupitchayan Oct 18, 2023
5fa512c
add back trigger on push for testing
sumupitchayan Oct 18, 2023
8ab7b97
remove if in step, add conditional to bash run script
sumupitchayan Oct 18, 2023
e1d5607
try removing == false from curly braces exp
sumupitchayan Oct 18, 2023
09745c0
switch auto-approve to test label, and seeif conditional works when t…
sumupitchayan Oct 18, 2023
0f7a611
see if removing braces works
sumupitchayan Oct 18, 2023
3e743be
add braces back
sumupitchayan Oct 18, 2023
2bfc382
switch conditional to 'github.event_name == push'
sumupitchayan Oct 18, 2023
3d3e83b
add 'bug' as test label
sumupitchayan Oct 18, 2023
94bb7b0
switch label back to auto-approve
sumupitchayan Oct 18, 2023
f203ae5
add label to branchName to test it's not blank
sumupitchayan Oct 18, 2023
3b30f9c
add label to PR title to see if blank AGAIN
sumupitchayan Oct 18, 2023
7a7ba74
try conditional if AGAIN
sumupitchayan Oct 18, 2023
894d30a
put push in quotes
sumupitchayan Oct 18, 2023
974de2e
fts
sumupitchayan Oct 18, 2023
fce1bec
add ! to conditional
sumupitchayan Oct 18, 2023
624f9c6
create separate testingmode job
sumupitchayan Oct 18, 2023
ec0ad03
add braces to github. conditional
sumupitchayan Oct 18, 2023
6fa0f13
fix conditional for non-testingmode job
sumupitchayan Oct 18, 2023
88aa12c
delete separate testing mode job
sumupitchayan Oct 18, 2023
752ad1c
comment out all testingMode lines for setting auto-approve labels
sumupitchayan Oct 18, 2023
26a0b13
switch npx projen build to yarn build
sumupitchayan Oct 19, 2023
7337ac4
put conditional in run again
sumupitchayan Oct 19, 2023
478967b
set conditional to eventName = push again
sumupitchayan Oct 19, 2023
4dcf39d
put push in quotes
sumupitchayan Oct 19, 2023
40abf88
add quotes around var name braces
sumupitchayan Oct 19, 2023
2d91ade
remove == . change to =
sumupitchayan Oct 19, 2023
04335d2
switch to brackets
sumupitchayan Oct 19, 2023
4bbaf29
switch to testing mode in brackets
sumupitchayan Oct 19, 2023
933ed62
put TRUE in conditional
sumupitchayan Oct 19, 2023
6fda541
switch back to parens to test
sumupitchayan Oct 19, 2023
ae8ca0b
put testingmode in parens
sumupitchayan Oct 19, 2023
c8e3004
fix conditional
sumupitchayan Oct 19, 2023
0052b0c
fix conditional remove second for now
sumupitchayan Oct 19, 2023
ce2a5c1
again ...
sumupitchayan Oct 19, 2023
7b292c9
add another paren
sumupitchayan Oct 19, 2023
7dc5a1e
switch back to equating with empty string
sumupitchayan Oct 19, 2023
9315cde
switch back to =
sumupitchayan Oct 19, 2023
c90702b
remove spaces in conditional
sumupitchayan Oct 19, 2023
fcef434
try out separate script file
sumupitchayan Oct 19, 2023
e151d12
try out separate script file ci
sumupitchayan Oct 19, 2023
ff77bce
try out separate script filefghhxghgfs
sumupitchayan Oct 19, 2023
b73fb1e
try out separate script filefghhxghgfsfhgfjghfhg
sumupitchayan Oct 19, 2023
439b8c8
edit bash file
sumupitchayan Oct 19, 2023
552880c
edit bash file gain
sumupitchayan Oct 19, 2023
7543dea
lksdbf
sumupitchayan Oct 19, 2023
b149b99
try AGAIN
sumupitchayan Oct 19, 2023
f158ada
spaces inside brackets
sumupitchayan Oct 19, 2023
dbd6c08
test testing mode tings
sumupitchayan Oct 19, 2023
d71d5d1
add else to if
sumupitchayan Oct 19, 2023
8f80224
laksdjbfn
sumupitchayan Oct 19, 2023
e2d2ca2
see if this works
sumupitchayan Oct 19, 2023
a3525f6
see if this works again
sumupitchayan Oct 19, 2023
f048e12
lasdjfbh
sumupitchayan Oct 19, 2023
bd2aa5d
rename bash file again
sumupitchayan Oct 19, 2023
42a6e7d
rename bash
sumupitchayan Oct 19, 2023
26e8b2b
move to second job
sumupitchayan Oct 19, 2023
1c702f4
fix script
sumupitchayan Oct 19, 2023
4aab2fb
fix ref to env var
sumupitchayan Oct 19, 2023
cfeab4b
test if label is added
sumupitchayan Oct 19, 2023
92aea9d
make configuring testing mode its own prerequisite job
sumupitchayan Oct 19, 2023
bdd374c
fix script typo
sumupitchayan Oct 19, 2023
31337ef
set label to bug for testing
sumupitchayan Oct 19, 2023
792a309
rename script files
sumupitchayan Oct 19, 2023
c3e8255
add spaces after brackets
sumupitchayan Oct 19, 2023
e629151
put conditional in second bash script
sumupitchayan Oct 19, 2023
8f36e41
fix
sumupitchayan Oct 19, 2023
afcc200
add then
sumupitchayan Oct 19, 2023
71bfcce
move then
sumupitchayan Oct 19, 2023
a5cc444
fts
sumupitchayan Oct 19, 2023
b0a2da5
lkasjbd
sumupitchayan Oct 19, 2023
9323529
fts
sumupitchayan Oct 19, 2023
6b13485
i solved the stupid error ....
sumupitchayan Oct 19, 2023
f326e11
nvm ,...
sumupitchayan Oct 19, 2023
42ca388
fix
sumupitchayan Oct 19, 2023
f3241fa
Merge branch 'master' into sumughan/fix-auto-approve-labelling
sumupitchayan Dec 15, 2023
815568e
make testingMode default true, also put the version reference update …
sumupitchayan Feb 20, 2024
dd4d63e
chore: self mutation
invalid-email-address Feb 20, 2024
998e017
switch setLabelsScript conditional
sumupitchayan Feb 20, 2024
3fd6d82
Merge branch 'sumughan/fix-auto-approve-labelling' of https://github.…
sumupitchayan Feb 20, 2024
42ef86e
add context and comments on setLabelsScript
sumupitchayan Feb 20, 2024
09a8d3f
create backport issue and close it
sumupitchayan Feb 20, 2024
4670b81
chore: self mutation
invalid-email-address Feb 20, 2024
c2a602a
remove list from labels
sumupitchayan Feb 20, 2024
2584444
Merge branch 'sumughan/fix-auto-approve-labelling' of https://github.…
sumupitchayan Feb 20, 2024
84a83ba
chore: self mutation
invalid-email-address Feb 20, 2024
d82a24c
run npx projen
sumupitchayan Feb 20, 2024
591a9f8
Merge branch 'sumughan/fix-auto-approve-labelling' of https://github.…
sumupitchayan Feb 20, 2024
a5a2667
add comment that issue creation is not working
sumupitchayan Feb 20, 2024
84d1065
make sure issue for backport label is being created in cdk8s-plus repo
sumupitchayan Feb 21, 2024
8548075
Merge branch 'master' into sumughan/fix-auto-approve-labelling
sumupitchayan Feb 21, 2024
3c365fa
try diff github create issue action
sumupitchayan Feb 21, 2024
7ff3e90
run npx projen
sumupitchayan Feb 21, 2024
d66426b
chore: self mutation
invalid-email-address Feb 21, 2024
d730abe
use original create issue action
sumupitchayan Feb 21, 2024
bcf946e
Merge branch 'sumughan/fix-auto-approve-labelling' of https://github.…
sumupitchayan Feb 22, 2024
75d2591
add step to update latest k8s version in txt file for update cdk8s we…
sumupitchayan Feb 22, 2024
022d89b
chore: self mutation
invalid-email-address Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/bump-latest-cdk8s-plus-library.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading