fixing issue #1507 by using FSM #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicitly trying to use epsilon or margin
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
+ Coverage 80.53% 80.61% +0.08%
==========================================
Files 121 121
Lines 3436 3451 +15
==========================================
+ Hits 2767 2782 +15
Misses 669 669 |
|
The original Issue #1507 was marked as Resolved since this behaviour is intended. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WHAT
This PR attempts to fix Issue #1507 by introducing a finite state machine (FSM) to determine the type of approximation that the user wants to perform. The default is using both and then OR'ing them.
WHY
As per Issue #1507 the inequality check will fail even though it is obviously correct. More simply, the equality is supposed to be wrong but Catch2 is reporting them as correct, because we performed an OR of epsilon_check and margin_check.
The problem seems to occur when the margin that is set by the user is smaller than the default epsilon, therefore, while margin_check will fail, epsilon_check will not.
GitHub Issues
Closes #1507