feat(dropdown): support new experimental error state #1733
Conversation
|
Deploy preview for the-carbon-components ready! Built with commit 9d5cdec https://deploy-preview-1733--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Just two things:
- The chevron needs to be 16 from the edge of the right side, and there needs to be a 8px space between the alert icon and the chevron.
- Also on Firefox, Chrome and Safari the type in the field needs to be in the exact center, right now it is a little too high.
|
thanks for the feedback, I've repositioned the alert icon to be 8px away from the chevron, and chevron is already 16px away from the edge. The type in the field was left unchanged from #1269 but I've modified it to be centered |
emyarod
force-pushed
the
1732-experimental-dropdown-error-state
branch
from
dd70ec8 to
4aa5294
Compare
|
Hi @laurenmrice was looking at the original issue (#1535) - Did you mean select UI (https://www.carbondesignsystem.com/components/select/code), dropdown, or both...? Thanks! |
|
Hey Akira, yes both types of dropdowns 👍 |
|
I just made the select error state changes separately in this PR #1756 |
|
🎉 This PR is included in version 9.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1732
Part of #1535
This PR adds the experimental error state to the dropdown component