Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release main #393

Merged
merged 2 commits into from
Feb 2, 2024
Merged

chore: release main #393

merged 2 commits into from
Feb 2, 2024

Conversation

cap-bots
Copy link
Collaborator

@cap-bots cap-bots commented Dec 20, 2023 •
edited
Loading

🤖 I have created a release beep boop

db-service: 1.6.0

1.6.0 (2024-02-02)

Added

  • Add fallback for @cap-js/hana for unknown entities (#403) (e7dd6de)
  • SELECT returns binaries as Buffers (#416) (d4240d5)
  • SELECT returns LargeBinaries as streams unless feature flag "stream_compat" is set (#251) (8165a4a)
  • strict mode to validate input for INSERT, UPDATE and UPSERT (#384) (4644483)
  • Support Readable Streams inside INSERT.entries (#343) (f6faf89)

Fixed

sqlite: 1.5.0

1.5.0 (2024-02-02)

Added

  • SELECT returns LargeBinaries as streams unless feature flag "stream_compat" is set (#251) (8165a4a)
  • Support Readable Streams inside INSERT.entries (#343) (f6faf89)

Fixed

postgres: 1.5.0

1.5.0 (2024-02-02)

Added

  • SELECT returns LargeBinaries as streams unless feature flag "stream_compat" is set (#251) (8165a4a)
  • Support Readable Streams inside INSERT.entries (#343) (f6faf89)

Fixed

  • switch Postgres from json to jsonb (#402) (c98a964)
  • UPSERT for @cap-js/hana for entities with multiple keys (#418) (9bbac6e)
hana: 0.0.4

0.0.4 (2024-02-02)

Added

  • Add fallback for @cap-js/hana for unknown entities (#403) (e7dd6de)
  • SELECT returns binaries as Buffers (#416) (d4240d5)
  • SELECT returns LargeBinaries as streams unless feature flag "stream_compat" is set (#251) (8165a4a)
  • Support Readable Streams inside INSERT.entries (#343) (f6faf89)

Fixed

  • Ensure globally unique aliases with large expand queries (#396) (c1df747)
  • enumeration issue with session context in @cap-js/hana (#399) (8106a20)
  • ignore empty order by (#392) (a69fed0)
  • improve != and == implementation for @cap-js/hana (#426) (9b7b5a0)
  • show clear error message when unable to load project package.json (#419) (2ebf783)
  • UPSERT for @cap-js/hana for entities with multiple keys (#418) (9bbac6e)

This PR was generated with Release Please. See documentation.

@patricebender patricebender mentioned this pull request Dec 20, 2023
Merged
patricebender
patricebender requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need #395 first

@cap-bots cap-bots force-pushed the release-please--branches--main branch from cec3ac5 to a222246 Compare December 20, 2023 15:02
@cap-bots cap-bots force-pushed the release-please--branches--main branch from a222246 to 33c9b01 Compare December 28, 2023 13:21
@BobdenOs
Copy link
Contributor

All services require the db-service dependencies to be bumped to the new version.

@cap-bots cap-bots force-pushed the release-please--branches--main branch from 33c9b01 to b3add60 Compare January 3, 2024 10:11
@cap-bots cap-bots force-pushed the release-please--branches--main branch 2 times, most recently from ff49bfa to 3a574b1 Compare January 9, 2024 08:56
BobdenOs
BobdenOs previously requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@BobdenOs BobdenOs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update db-service version in all other packages before merging.

@cap-bots cap-bots force-pushed the release-please--branches--main branch 4 times, most recently from 2ffeb2f to 3ceaece Compare January 12, 2024 14:14
@cap-bots cap-bots force-pushed the release-please--branches--main branch 6 times, most recently from 0ad0fb7 to 927c58e Compare January 22, 2024 11:42
@cap-bots cap-bots force-pushed the release-please--branches--main branch from 927c58e to 733c8f8 Compare January 22, 2024 16:04
@cap-bots cap-bots force-pushed the release-please--branches--main branch 7 times, most recently from 3678262 to e9836ec Compare February 1, 2024 19:42
@johannes-vogel
Copy link
Contributor

johannes-vogel commented Feb 1, 2024 •
edited
Loading

@BobdenOs @patricebender from my point of view we are ready to go.

For some reason release-please removed my commits for increasing db-service version and cds peer version:
63452b6
c19a7c3

.Could you please double check how we can include those :)
Maybe https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#node-workspace?

@patricebender
Copy link
Member

patricebender commented Feb 2, 2024 •
edited
Loading

@BobdenOs @patricebender from my point of view we are ready to go.

For some reason release-please removed my commits for increasing db-service version and cds peer version: 63452b6 c19a7c3

.Could you please double check how we can include those :) Maybe https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#node-workspace?

Screenshot 2024-02-02 at 09 53 38

Looks strange, did you directly pushed this change to this branch? Maybe increase the versions in a PR instead?

@sjvans
Copy link
Contributor

sjvans commented Feb 2, 2024 •
edited
Loading

@BobdenOs @patricebender #437

... ok, we can't bump db-service version as 1.6 isn't released yet 😅

how do you normally handle this?

@patricebender
Copy link
Member

patricebender commented Feb 2, 2024 •
edited
Loading

@BobdenOs @patricebender #437

... ok, we can't bump db-service version as 1.6 isn't released yet 😅

how do you normally handle this?

in a perfect world we would separately release the db-service and then bump the versions in the other packages. I would propose that we force merge #437 and immediately release our services after. Edit: oh, i guess then the release pipeline would fail :( I will check if there is a mechanism in release please to release the db-service separately → I think Johannes already found the feature:

Maybe https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#node-workspace?

@sjvans
Copy link
Contributor

sjvans commented Feb 2, 2024

in a perfect world we would separately release the db-service and then bump the versions in the other packages.

we can't do that in two separate prs?

@patricebender
Copy link
Member

in a perfect world we would separately release the db-service and then bump the versions in the other packages.

we can't do that in two separate prs?

I think I can release the db-service separately, via CLI, never done it before but I will try

@BobdenOs
Copy link
Contributor

BobdenOs commented Feb 2, 2024

What I read from the node-workspace plugin it always bumps the version. Which is something we didn't want to do.

I guess force merging #437 should work, right ?

@patricebender
Copy link
Member

What I read from the node-workspace plugin it always bumps the version. Which is something we didn't want to do.

I guess force merging #437 should work, right ?

I guess the release pipeline would then fail :(

@cap-bots cap-bots force-pushed the release-please--branches--main branch from e9836ec to d1584c6 Compare February 2, 2024 13:37
@sjvans sjvans requested a review from BobdenOs February 2, 2024 13:41
sjvans
sjvans approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patricebender patricebender merged commit cbb584c into main Feb 2, 2024
4 checks passed
@patricebender patricebender deleted the release-please--branches--main branch February 2, 2024 13:55
@cap-bots
Copy link
Collaborator Author

cap-bots commented Feb 2, 2024

🤖 Release is at https://github.com/cap-js/cds-dbs/releases/tag/db-service-v1.6.0 🌻

@cap-bots
Copy link
Collaborator Author

cap-bots commented Feb 2, 2024

🤖 Release is at https://github.com/cap-js/cds-dbs/releases/tag/sqlite-v1.5.0 🌻

@cap-bots
Copy link
Collaborator Author

cap-bots commented Feb 2, 2024

🤖 Release is at https://github.com/cap-js/cds-dbs/releases/tag/postgres-v1.5.0 🌻

@cap-bots
Copy link
Collaborator Author

cap-bots commented Feb 2, 2024

🤖 Release is at https://github.com/cap-js/cds-dbs/releases/tag/hana-v0.0.4 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricebender patricebender patricebender approved these changes

@sjvans sjvans sjvans approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@gregorwolf gregorwolf Awaiting requested review from gregorwolf gregorwolf is a code owner

@sebastianesch sebastianesch Awaiting requested review from sebastianesch sebastianesch is a code owner

@vobu vobu Awaiting requested review from vobu vobu is a code owner

@BobdenOs BobdenOs Awaiting requested review from BobdenOs BobdenOs is a code owner

Assignees
No one assigned
Labels
autorelease: tagged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite: Update can lead to Uncaught RangeError: Invalid time value
5 participants
@cap-bots @BobdenOs @johannes-vogel @patricebender @sjvans