Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noop #546

Merged
merged 1 commit into from
May 19, 2015
Merged

Noop #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions lib/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
(function () {

var async = {};
var noop = function () {};

// global on the server, window in the browser
var root, previous_async;
Expand Down Expand Up @@ -113,7 +114,7 @@
}

async.each = function (arr, iterator, callback) {
callback = callback || function () {};
callback = callback || noop;
if (!arr.length) {
return callback();
}
Expand All @@ -124,7 +125,7 @@
function done(err) {
if (err) {
callback(err);
callback = function () {};
callback = noop;
}
else {
completed += 1;
Expand All @@ -137,7 +138,7 @@
async.forEach = async.each;

async.eachSeries = function (arr, iterator, callback) {
callback = callback || function () {};
callback = callback || noop;
if (!arr.length) {
return callback();
}
Expand All @@ -146,7 +147,7 @@
iterator(arr[completed], function (err) {
if (err) {
callback(err);
callback = function () {};
callback = noop;
}
else {
completed += 1;
Expand All @@ -172,7 +173,7 @@
var _eachLimit = function (limit) {

return function (arr, iterator, callback) {
callback = callback || function () {};
callback = callback || noop;
if (!arr.length || limit <= 0) {
return callback();
}
Expand All @@ -191,7 +192,7 @@
iterator(arr[started - 1], function (err) {
if (err) {
callback(err);
callback = function () {};
callback = noop;
}
else {
completed += 1;
Expand Down Expand Up @@ -342,7 +343,7 @@
iterator(x, function (result) {
if (result) {
main_callback(x);
main_callback = function () {};
main_callback = noop;
}
else {
callback();
Expand All @@ -360,7 +361,7 @@
iterator(x, function (v) {
if (v) {
main_callback(true);
main_callback = function () {};
main_callback = noop;
}
callback();
});
Expand All @@ -376,7 +377,7 @@
iterator(x, function (v) {
if (!v) {
main_callback(false);
main_callback = function () {};
main_callback = noop;
}
callback();
});
Expand Down Expand Up @@ -414,7 +415,7 @@
};

async.auto = function (tasks, callback) {
callback = callback || function () {};
callback = callback || noop;
var keys = _keys(tasks);
var remainingTasks = keys.length
if (!remainingTasks) {
Expand Down Expand Up @@ -446,7 +447,7 @@
if (!remainingTasks) {
var theCallback = callback;
// prevent final callback from calling itself if it errors
callback = function () {};
callback = noop;

theCallback(null, results);
}
Expand All @@ -467,7 +468,7 @@
safeResults[k] = args;
callback(err, safeResults);
// stop subsequent errors hitting callback multiple times
callback = function () {};
callback = noop;
}
else {
results[k] = args;
Expand Down Expand Up @@ -527,7 +528,7 @@
};

async.waterfall = function (tasks, callback) {
callback = callback || function () {};
callback = callback || noop;
if (!_isArray(tasks)) {
var err = new Error('First argument to waterfall must be an array of functions');
return callback(err);
Expand All @@ -539,7 +540,7 @@
return function (err) {
if (err) {
callback.apply(null, arguments);
callback = function () {};
callback = noop;
}
else {
var args = Array.prototype.slice.call(arguments, 1);
Expand All @@ -560,7 +561,7 @@
};

var _parallel = function(eachfn, tasks, callback) {
callback = callback || function () {};
callback = callback || noop;
if (_isArray(tasks)) {
eachfn.map(tasks, function (fn, callback) {
if (fn) {
Expand Down Expand Up @@ -600,7 +601,7 @@
};

async.series = function (tasks, callback) {
callback = callback || function () {};
callback = callback || noop;
if (_isArray(tasks)) {
async.mapSeries(tasks, function (fn, callback) {
if (fn) {
Expand Down