breaking: remove during, make test functions in until/whilst async #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hargasinski
reviewed
Jul 11, 2018
lib/until.js
Outdated
| @@ -13,15 +14,30 @@ import whilst from './whilst'; | |||
| * @method | |||
| * @see [async.whilst]{@link module:ControlFlow.whilst} | |||
| * @category Control Flow | |||
| * @param {Function} test - synchronous truth test to perform before each | |||
| * execution of `iteratee`. Invoked with (). | |||
| * @param {Function} test - asynchronous truth test to perform before each | |||
There was a problem hiding this comment.
nit: I think the parameter type is AsyncFunction.
hargasinski
reviewed
Jul 11, 2018
lib/doUntil.js
Outdated
| * @param {Function} test - synchronous truth test to perform after each | ||
| * execution of `iteratee`. Invoked with any non-error callback results of | ||
| * `iteratee`. | ||
| * @param {Function} test - asynchronous truth test to perform after each |
There was a problem hiding this comment.
nit: Sorry, same as before, I think the param type is AsyncFunction.
hargasinski
approved these changes
Jul 11, 2018
|
LGTM. Should we add |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #850