Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint zeebe:TaskSchedule Extension Elements #48

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Lint zeebe:TaskSchedule Extension Elements #48

merged 5 commits into from
Mar 22, 2023

Conversation

philippfromme
Copy link
Collaborator

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 16, 2023
@philippfromme
Copy link
Collaborator Author

Requires camunda/bpmnlint-plugin-camunda-compat#86 to be merged first.

@philippfromme philippfromme mentioned this pull request Mar 20, 2023
Closed
@philippfromme
Copy link
Collaborator Author

With bpmnlint-plugin-camunda-compat integrated this is ready to be reviewed.

marstamm
marstamm approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

We should also update the dev dependency for bpmn-js-properties-panel once it is released so it can be tested with npm start without linking it manually

@merge-me merge-me bot merged commit 9efdd6a into main Mar 22, 2023
@merge-me merge-me bot deleted the task-schedule branch March 22, 2023 13:37
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@smbea smbea Awaiting requested review from smbea

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @marstamm